| commit | 013513c98096e254b94bbbe1d7e23a00064ef2de | [log] [tgz] |
|---|---|---|
| author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Fri Feb 22 19:16:42 2019 +0100 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 22 18:43:05 2019 +0000 |
| tree | 02806414b9e09bde99406d05236be3cc1575489e | |
| parent | 1152229e674d70654a852c73f0354581d3ab6b95 [diff] |
gn recipe: Do not pass libraries in LDFLAGS in the Linux recipe
The existing recipe was added before the GN build switched to libc++ and
//build/gen.py started setting flags such as -static-libstdc++ -ldl
-lpthread on its own.
The recipe's settings are now redundant and actually hide bugs from the
bots. For example, commit 082fbe397d ("Pass -lpthread when linking instead
of -pthread") should have broken the bot, but since it is explicitly passing
-lpthread in LDFLAGS the build continued working.
Bug: chromium:934793
Change-Id: I634a1b6206b5af2e9df53005ccbe8547f56eb0c7
Reviewed-on: https://gn-review.googlesource.com/c/4080
Reviewed-by: Petr Hosek <phosek@google.com>
Commit-Queue: Petr Hosek <phosek@google.com>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.