| commit | 091169beda92aff21ded3e9dfb392ea12b10c0e0 | [log] [tgz] |
|---|---|---|
| author | Torne (Richard Coles) <torne@google.com> | Fri Sep 21 13:27:29 2018 -0400 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Sep 21 17:55:44 2018 +0000 |
| tree | 9f801ec8dd8f7b134dad386e757c1a6699095c7b | |
| parent | b25107e9cf772feec1dadf6fa6e3a3620b9c9726 [diff] |
Fix error messages for invalid array subscripts. Previously the error for an out-of-range array subscript was off by one when indicating the valid range. Fix this, and print a different message for the case where the array is empty as this would not make sense for the existing error message. Change-Id: I2aba48c21559a47ce159d8dac2d0adc4fbcb310a Reviewed-on: https://gn-review.googlesource.com/2860 Reviewed-by: Scott Graham <scottmg@google.com> Commit-Queue: Scott Graham <scottmg@google.com>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/.
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.