tree dde549a5d075648875a35577c8468de7db4b1086
parent 8b973aa51d02aa1ab327100007d4070c24b862b0
author Reito <carolwolfking@gmail.com> 1708062629 +0800
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1708077261 +0000

Fix regression in MakeRelativePath()

The logic in the function only works correctly when the
`input` and `dest` arguments are zero-terminated strings.
Changing them to std::string_view in a previous CL broke
this assumption, resulting in buffer overflows, runtime
errors with stdlib++ assertions turned on.

Fixed: 358
Change-Id: Idfb52ffcbc38943ca5c8d231fae2fd0c50f20fd3
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/16700
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: David Turner <digit@google.com>
Reviewed-by: David Turner <digit@google.com>