win: Don't use rsp files when linking gn either. The longest link line in gn is < 3000 bytes (gn_lib.lib) and even if gn_lib was a source set, the link line for gn_unittests.exe would still be less than 8000 bytes, so we're comfortably below the limit where rsp files are needed. While here, change flag order to be more like on linux and mac. No behavior change. Change-Id: Ie76c8a9892af20559e3c7d5d04ae77332470aee2 Reviewed-on: https://gn-review.googlesource.com/c/gn/+/6460 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
diff --git a/build/build_win.ninja.template b/build/build_win.ninja.template index 60c970f..f53fe64 100644 --- a/build/build_win.ninja.template +++ b/build/build_win.ninja.template
@@ -9,13 +9,9 @@ deps = msvc rule alink_thin - command = ninja -t msvc -- $ar /nologo /ignore:4221 /OUT:$out @$out.rsp + command = ninja -t msvc -- $ar /nologo /ignore:4221 $libflags /OUT:$out $in description = LIB $out - rspfile = $out.rsp - rspfile_content = $in_newline $libflags rule link - command = ninja -t msvc -- $ld /nologo /OUT:$out /PDB:$out.pdb @$out.rsp + command = ninja -t msvc -- $ld /nologo $ldflags /OUT:$out /PDB:$out.pdb $in $solibs $libs description = LINK $out - rspfile = $out.rsp - rspfile_content = $in_newline $libs $solibs $ldflags