)]}'
{
  "commit": "dcab2f94a3e5f1e52e4f030becfbf138117c7b8c",
  "tree": "a99ea8309fbb172ecbb60bfb247ba6cc981d5d1c",
  "parents": [
    "d46f92f4465be387dcf96fd6be070e8791b59763"
  ],
  "author": {
    "name": "Sylvain Defresne",
    "email": "sdefresne@chromium.org",
    "time": "Wed Apr 03 16:34:05 2019 +0200"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Wed Apr 03 15:12:37 2019 +0000"
  },
  "message": "Fix issues with bundle_data/create_bundle targets\n\nRemove the bundle_plugins_dir variable as it is not really required\n(the value is always the same for both iOS and macOS) and the value\ncan be inlined instead ({{bundle_contents_dir}}/Plugins).\n\nFix NinjaCreateBundleTargetWriter to only complain about missing\ncompile_xcassets tool if the target require it (i.e. if it defines\na list of resources to compile in an asset catalog).\n\nFix incorrect use of deps instead of public_deps in bundle_data\ndocumentation.\n\nBug: https://bugs.chromium.org/p/gn/issues/detail?id\u003d64\nChange-Id: I28a0a3d673dc1b39804c466499e6e91f034a2113\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/4480\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9571fb3c6e1834df257cb52ea0abd028eab903ba",
      "old_mode": 33188,
      "old_path": "docs/reference.md",
      "new_id": "fe23b196b849acb9de7497714f11edb990d54084",
      "new_mode": 33188,
      "new_path": "docs/reference.md"
    },
    {
      "type": "modify",
      "old_id": "60254a9f92779a4d4b5e3e71121f4f55bfe505e4",
      "old_mode": 33188,
      "old_path": "tools/gn/bundle_data.h",
      "new_id": "2379dbc568d250b533b17368937173582c630c4d",
      "new_mode": 33188,
      "new_path": "tools/gn/bundle_data.h"
    },
    {
      "type": "modify",
      "old_id": "78012a071814dd82279fa3fe90baff619d713f4f",
      "old_mode": 33188,
      "old_path": "tools/gn/bundle_file_rule.cc",
      "new_id": "5dffb07e929c24b888ae22c7354e506f8be56e01",
      "new_mode": 33188,
      "new_path": "tools/gn/bundle_file_rule.cc"
    },
    {
      "type": "modify",
      "old_id": "768697da5e742cf2b229e955a1ece8603ec81bff",
      "old_mode": 33188,
      "old_path": "tools/gn/create_bundle_target_generator.cc",
      "new_id": "3556b5d86c83413cff43e22ce1b25fe01fbf4672",
      "new_mode": 33188,
      "new_path": "tools/gn/create_bundle_target_generator.cc"
    },
    {
      "type": "modify",
      "old_id": "d0298439d83c67e96ba0bd2d618fecef0b6b3546",
      "old_mode": 33188,
      "old_path": "tools/gn/desc_builder.cc",
      "new_id": "57f27fdbfa473a02dfe060705c27c97ddf88712b",
      "new_mode": 33188,
      "new_path": "tools/gn/desc_builder.cc"
    },
    {
      "type": "modify",
      "old_id": "72ccf930e1bf04a82519c3f3a2f1f31a714f2527",
      "old_mode": 33188,
      "old_path": "tools/gn/functions_target.cc",
      "new_id": "be02fc420cb8d57a6ea1c461b726dcfb92b6e148",
      "new_mode": 33188,
      "new_path": "tools/gn/functions_target.cc"
    },
    {
      "type": "modify",
      "old_id": "aa33133869d7d53028628529417ae4749178de2d",
      "old_mode": 33188,
      "old_path": "tools/gn/misc/emacs/gn-mode.el",
      "new_id": "5930b585220fabf894415c3277fb3a9c3abc6a0b",
      "new_mode": 33188,
      "new_path": "tools/gn/misc/emacs/gn-mode.el"
    },
    {
      "type": "modify",
      "old_id": "cc816e128ac0a7b6e71cbba4ef3d483546fdfcc4",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_create_bundle_target_writer.cc",
      "new_id": "cfc3d91dbdb0ac3297d7faaaf9fd8b52b2a51e7c",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_create_bundle_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "3c62c59d13376c57faccc0597291b0ab89a0ad9d",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_create_bundle_target_writer_unittest.cc",
      "new_id": "af7a7f5618bc01bc2c8629be91b8a8fdaa6b013d",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_create_bundle_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "8c0fbb4c30cee561f9b3121ae4a15b6436a9338e",
      "old_mode": 33188,
      "old_path": "tools/gn/substitution_type.cc",
      "new_id": "d47a8d0fdc68ce080ea52feed3a38c34be7b25e9",
      "new_mode": 33188,
      "new_path": "tools/gn/substitution_type.cc"
    },
    {
      "type": "modify",
      "old_id": "7363e1872467e0f1da297bfd6ad57d8d216ba3f9",
      "old_mode": 33188,
      "old_path": "tools/gn/substitution_type.h",
      "new_id": "9e2bdb728b9b47bd54423071b33fa211c8af668f",
      "new_mode": 33188,
      "new_path": "tools/gn/substitution_type.h"
    },
    {
      "type": "modify",
      "old_id": "b2d70fe763ddc2621d8cc336e3e06f9dda3beaac",
      "old_mode": 33188,
      "old_path": "tools/gn/target_unittest.cc",
      "new_id": "673422e92c80927b72ac699b3e67a755a18c4db3",
      "new_mode": 33188,
      "new_path": "tools/gn/target_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "d63a2a72997d3138baa064eef5f238266c8a3ac5",
      "old_mode": 33188,
      "old_path": "tools/gn/variables.cc",
      "new_id": "a809a1cc54d7a0bd049efe0aef9d5fde2b4b5f4e",
      "new_mode": 33188,
      "new_path": "tools/gn/variables.cc"
    },
    {
      "type": "modify",
      "old_id": "0ef15b8824cfe573b03d50738e185023d46c245c",
      "old_mode": 33188,
      "old_path": "tools/gn/variables.h",
      "new_id": "09f2c1872edbf897ae26e9a31ca4417622a9e82f",
      "new_mode": 33188,
      "new_path": "tools/gn/variables.h"
    }
  ]
}