tree 2160e4ef267f605ffce60fac75d2e3fd405fc956
parent 5705e56a0e5856621415cfdf444432554e72c9c9
author David 'Digit' Turner <digit@google.com> 1661859307 +0200
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1661938718 +0000

Do not remove build.ninja.d during `gn clean`

Calling `gn clean` would remove the `build.ninja.d` file
unexpectedly, which resulted in the nexty `gn clean` call
to fail with a "This does not look like a build directory" error.

The reason for this is a recent change [1] which modified how
the dummy `build.ninja` and `build.ninja.d` files generated
by `gn clean` (to force a regeneration on the next Ninja invocation)
are written:

- Before the CL, the code removed everything except `args.gn`, then
  wrote the dummy `build.ninja` and `build.ninja.d`.

- After the CL, the code wrote `build.ninja` and `build.ninja.d`,
  then removed everything except `args.gn` and `build.ninja`
  (this removing the just-written `build.ninja.d` file).

This fixes the issue by ensuring that `build.ninja.d` is not
removed. Moreover, this relaxes the build directory check logic
a little, by accepting a directory that only contains an `args.gn`
file, without a `build.ninja.d` file in it.

[1] https://gn-review.googlesource.com/c/gn/+/14200

Bug: None

Change-Id: Ie06ab751bed5a749a63bf200b50424abdcf0fdcf
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/14500
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: David Turner <digit@google.com>
Reviewed-by: Petr Hosek <phosek@google.com>