tree 17e20104116d49516b01a68c388f34e55f3252ed
parent 91232af7609c56180a299d4d90f3e3d8a4c2176d
author Brett Wilson <brettw@openai.com> 1777938239 -0700
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1779094898 -0700

Enhance quiet mode.

Quiet mode (-q) is documented as "Don't print output on success." But
this doesn't apply to many categories of output. In particular, warning
output is still printed. If the build produces warnings, scripts that
consume the output of GN commands like "desc" can get corrupted output
and these lines need to be manually filtered.

This patch extends quiet mode to buffer the output until an error is
hit. If the run produces an error, this output is printed to standard
out as normal. If the run succeeds, this output is discarded. This
implements the spirit of quite mode more completely and allows cleaner
programmatic consumption of the output.

Also fixes an existing issue where Python error output would be
discarded in quiet mode.

In this patch we lose a fflush() at the end of the implementation of the
print() function call. We could special-case this to flush in the
non-quiet case, but I don't think the flush is necessary any more for
normal usage (this was more relevant when doing initial development).

Change-Id: Ibef6ed2c23e130e8336c16fbab9aad4dff63e131
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/22680
Commit-Queue: David Turner <digit@google.com>
Reviewed-by: Tate Wyatt <wyatttate545@gmail.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Reviewed-by: David Turner <digit@google.com>
Reviewed-by: Matt Stark <msta@google.com>