tree b00a990bf13e9ebd789956b03b9e969647e858da
parent 80a40b07305373617eba2d5878d353532af77da3
author David 'Digit' Turner <digit@google.com> 1642504441 +0100
committer Commit Bot <commit-bot@chromium.org> 1642786148 +0000

Remove misc GCC-related compiler warnings.

When building GN with GCC, several warnings are printed
by the compiler about minor issues. This CL fixes these.

- src/gn/desc_builder.cc, src/gn/parser.cc, src/gn/visibility.cc:
  Remove redundant std::move() in return statements. These are
  harmless, except that they prevent copy-elision optimization
  in the generated code.

- src/gn/target.cc: Remove the unused 'rstool' variable.

- src/gn/pointer_set.h: Call the base default constructor
  explicitly in the PointerSet copy-constructor. Note that
  this is the default compiler behaviour, so this doesn´t
  change the generated code.

- src/base/compiler_specific.h: Update the FALLTHROUGH macro
  definition for C++17, removing a compiler warning in
  src/base/json/json_parser.cc.

Bug: None

Change-Id: I098f5edcf95f82cdfef0161cc637711111a3ff42
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/12820
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: David Turner <digit@google.com>