tree 10bd720e46d0c48d43f1c4cdc711a72c363161a1
parent 0035961837fbcfe875d855744b3eda4fd2eefb43
author Matt Stark <msta@google.com> 1791855734 +1100
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1791859016 -0700

Make StringAtom use pointer equality and hashing

StringAtom previously used string equality and hashing. The rationale
was that it would ensure consistent ordering with standard containers.
* This makes perfect sense for ordered containers, as operator< sorting
  lexicographically both makes sense and is frequently used.
* This makes zero sense for operator==, as pointers can be equal iff
  contents are equal, so whether it uses string or pointer equality is
  an implementation detail.
* This also makes no sense for hashing, as the C++ standard states that
  hashes are not required to be deterministic, and thus may be seeded
  upon binary start (though in practice this is not usually the case).

Change-Id: I58eeba92bba7723f8a9792d78b5ab5de6a6a6964
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/27480
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Matt Stark <msta@google.com>