commit | 0ac93dd23bafdae516d4d5318c7b748c5c98b489 | [log] [tgz] |
---|---|---|
author | Khouri Giordano <kirmeo@gmail.com> | Fri Feb 22 11:01:35 2019 -0500 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 22 16:58:15 2019 +0000 |
tree | c0cdce7cf64a5e6a1740c872f11b75650be19cd6 | |
parent | 1ab6fa2cab7ec64840db720a56018ca8939329f9 [diff] |
For proper order put -lpthreads as a 'library' not a 'linker flag' Linker flags appear early among the link command line arguments, before other libraries that need pthreads. Changing it to a library puts it at the end of the command line. Change-Id: I2d0cc5e44a33d72f9fcaa67f3a6fbc0da565a735 Reviewed-on: https://gn-review.googlesource.com/c/4060 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe
, link.exe
, and lib.exe
can be found in PATH
, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++
, a recent version is expected to be found in PATH
. This can be overridden by setting CC
, CXX
, and AR
.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.