)]}' { "commit": "0b087f15381f50ed6fd580cea0c0efd58096d3ea", "tree": "81e58b95d5ae50ab71027af729c8c1f5c16314b3", "parents": [ "404e06ead694c9a7e446a2a95c2292bd68ae5995" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Fri Apr 01 09:52:59 2022 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 01 02:06:08 2022 +0000" }, "message": "Reland \"make recipes python3 compatible\"\n\nThis reverts commit 93f0d7a7d3ade923b6d0b36b3df0ffacbe7e9f5d.\n\nReason for revert:\nuse /dev/null instead of \u0027-\u0027 (stdin) for xcrun toolchain step.\n\nConfirmed with\n$ led get-build 8818214129795863857 | led edit-recipe-bundle | \\\n led launch\nhttps://ci.chromium.org/raw/build/logs.chromium.org/gn/led/tikuta_google.com/7595c787826548d51e7f033368220d2595ca3e39179dffb6c2c72d93762af62a/+/build.proto?server\u003dchromium-swarm.appspot.com\n\nOriginal change\u0027s description:\n\u003e Revert \"make recipes python3 compatible\"\n\u003e\n\u003e This reverts commit ee7f7afa7e606888e36c2a7dd9d44e8c8040051e.\n\u003e\n\u003e Reason for revert:\n\u003e Culprit of timeout in\n\u003e https://ci.chromium.org/ui/p/gn/builders/try/mac/b8818214129795863857/overview\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e make recipes python3 compatible\n\u003e \u003e\n\u003e \u003e This updates recipes.py with\n\u003e \u003e $ curl https://chromium.googlesource.com/infra/luci/recipes-py/+/1b1ecd03e0b00399784c43add1465f685b6d1ab9/recipes.py?format\u003dTEXT |\\\n\u003e \u003e base64 -d \u003e infra/recipes.py\n\u003e \u003e\n\u003e \u003e And fixed some str/bytes usage in step/raw_io recipe modules.\n\u003e \u003e\n\u003e \u003e Bug: 283\n\u003e \u003e Change-Id: Ib714244beb8971dcbd462544069fcb60c9b58a01\n\u003e \u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/13400\n\u003e \u003e Reviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n\u003e \u003e Commit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n\u003e\n\u003e TBR\u003dphosek@google.com,brettw@google.com,tikuta@google.com\n\u003e\n\u003e Change-Id: If4fe0fe2a1ca487e98d78992eebb8bcb058eb060\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Bug: 283\n\u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/13441\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\u003e Commit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n\n# Not skipping CQ checks because this is a reland.\n\nBug: 283\nChange-Id: I39dcbd060abe2d7137352a71dcb0e13a3340d9b4\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/13480\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "fabdf8542ebe753ddd69bfd4f0d6737afd10573a", "old_mode": 33188, "old_path": "infra/README.recipes.md", "new_id": "c2737de2c7ffaed41b66409263fe8cfa1833bf71", "new_mode": 33188, "new_path": "infra/README.recipes.md" }, { "type": "modify", "old_id": "45963824ce858e0464cb57c224f07884047541e0", "old_mode": 33188, "old_path": "infra/config/recipes.cfg", "new_id": "df78f4f8792b4c9fbe1448257ce688bae1ac7f79", "new_mode": 33188, "new_path": "infra/config/recipes.cfg" }, { "type": "modify", "old_id": "56b6a9450edb59a655e5c84cb08703ebf0cbd874", "old_mode": 33188, "old_path": "infra/recipe_modules/macos_sdk/__init__.py", "new_id": "550f4335efb5f664a1f877aab45f0da2456d12d4", "new_mode": 33188, "new_path": "infra/recipe_modules/macos_sdk/__init__.py" }, { "type": "modify", "old_id": "a3348ab9402c836b21b90b83c380b53fdb527281", "old_mode": 33188, "old_path": "infra/recipe_modules/macos_sdk/examples/full.py", "new_id": "242e3c5bf00298828519855214dc6995cbab9a65", "new_mode": 33188, "new_path": "infra/recipe_modules/macos_sdk/examples/full.py" }, { "type": "modify", "old_id": "1239fd2864292ebc8ba9c20cb0febb26989ac8eb", "old_mode": 33188, "old_path": "infra/recipe_modules/target/__init__.py", "new_id": "a4f37aef4b6d34358787977336bfd06c9e14dbe1", "new_mode": 33188, "new_path": "infra/recipe_modules/target/__init__.py" }, { "type": "modify", "old_id": "c47c86a3f6b7ffe81d37a6e2ee49150366793e19", "old_mode": 33188, "old_path": "infra/recipe_modules/target/examples/full.py", "new_id": "0a2090a3fe0388cc607893909f95335f84dd0d11", "new_mode": 33188, "new_path": "infra/recipe_modules/target/examples/full.py" }, { "type": "modify", "old_id": "83323a8e13e22e978577a3e2978de5e98d5ef3c0", "old_mode": 33188, "old_path": "infra/recipe_modules/windows_sdk/__init__.py", "new_id": "51b849204c460e3bcec05e3637bdda3a9f78ad1e", "new_mode": 33188, "new_path": "infra/recipe_modules/windows_sdk/__init__.py" }, { "type": "modify", "old_id": "902c4918fa488b692672c6fb6271971f79b3e85a", "old_mode": 33188, "old_path": "infra/recipe_modules/windows_sdk/examples/full.py", "new_id": "029e997bb3d2b6518371e0f14b86877bcc1660ff", "new_mode": 33188, "new_path": "infra/recipe_modules/windows_sdk/examples/full.py" }, { "type": "modify", "old_id": "2fe00862255a85cd01719cdb7abd0a3bfa484822", "old_mode": 33261, "old_path": "infra/recipes.py", "new_id": "81b0bc6edd2e4dbf64786ab07d03521a07833c10", "new_mode": 33261, "new_path": "infra/recipes.py" }, { "type": "modify", "old_id": "e63326d457da5b8666eaec7a519ff0de395af588", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/ci_linux.json", "new_id": "25250ba44a4658493892065cfb90f235176e137d", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/ci_linux.json" }, { "type": "modify", "old_id": "90114aded03a646a92913300789108bad375b155", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/ci_mac.json", "new_id": "26af61daddbba167371da9fa8c97d4a04cbfc382", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/ci_mac.json" }, { "type": "modify", "old_id": "fcdc6582eccae37b2cf7b7b61ed168cc56ae487f", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/ci_win.json", "new_id": "e1a74d6e2d1a9e32cf113600e05fd2c8c66a0db3", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/ci_win.json" }, { "type": "modify", "old_id": "0a5dba9915e6b0eed58dd077df1dd4681f568f22", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/cipd_exists.json", "new_id": "abde3b58882ef2e3353e7dd7c59a6a013dc9f5b9", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/cipd_exists.json" }, { "type": "modify", "old_id": "b5e173a24cf14241c30601a2c92a0861d7a25ba9", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/cipd_register.json", "new_id": "0d3ce423895ada782f66cddf66236da5f7d84f5b", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/cipd_register.json" }, { "type": "modify", "old_id": "daea41e24a310ba7c061356a1a62c35ff93032dd", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/cq_linux.json", "new_id": "d19691ec986a985e12ba39d4acd0763e8510b66e", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/cq_linux.json" }, { "type": "modify", "old_id": "908c60daf8ae4927a05a1b95e0819d2af1af8875", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/cq_mac.json", "new_id": "4017d0b3c69a33ae48d74cc52cc996c35707b6dc", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/cq_mac.json" }, { "type": "modify", "old_id": "5612924b5b693d12db6fc18c2467acfd7516afad", "old_mode": 33188, "old_path": "infra/recipes/gn.expected/cq_win.json", "new_id": "df7c728f6075703f7d9f8fd6318f85ceef60907a", "new_mode": 33188, "new_path": "infra/recipes/gn.expected/cq_win.json" }, { "type": "modify", "old_id": "e8fcff1c0021859d8883035a120a3871e72e4b2b", "old_mode": 33188, "old_path": "infra/recipes/gn.py", "new_id": "4f1ea3df5957465b63acb2289b7ad6d7222b0c84", "new_mode": 33188, "new_path": "infra/recipes/gn.py" } ] }