)]}' { "commit": "0c5557d173ce217cea095086a9c9610068123503", "tree": "306a92dc794c8c44099fb72a7f9f4178ce95b2f4", "parents": [ "2426c173819e74a9dad7a2ab647cfa1506f6007f" ], "author": { "name": "Adrian Taylor", "email": "adetaylor@chromium.org", "time": "Fri Jan 10 11:58:23 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jan 10 20:31:12 2020 +0000" }, "message": "Fix Rust linking -lfoo.so not -lfoo due to TOC\n\nSome toolchains generate a .so.TOC as well as a .so file when creating\nshared libraries; they did not previously link correctly into downstream\nRust targets because the generated Ninja rules asked to link to -lfoo.so\nrather than -lfoo.\n\nThe unit test code here is a bit verbose. It seemed desirable to test\nwith a toolchain that generates TOC files and one that does not.\nHowever, that may be overkill.\n\nBug: crbug.com/gn/137\nChange-Id: I30918957f8da187c5a1fc3e8f76d91fe5fda494f\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/7020\nReviewed-by: Adrian Taylor \u003cadetaylor@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "729bfc72c0760039814c8ac47e1e01e81bd334f6", "old_mode": 33188, "old_path": "src/gn/ninja_rust_binary_target_writer.cc", "new_id": "2ac19780a04be1c9b8938f73855f9f40e878026e", "new_mode": 33188, "new_path": "src/gn/ninja_rust_binary_target_writer.cc" }, { "type": "modify", "old_id": "d581b2145df75dd50554505681c802cb0c8df0f9", "old_mode": 33188, "old_path": "src/gn/ninja_rust_binary_target_writer_unittest.cc", "new_id": "44ff61c0642d40e50541a619860c0fc9656cda44", "new_mode": 33188, "new_path": "src/gn/ninja_rust_binary_target_writer_unittest.cc" }, { "type": "modify", "old_id": "06a87725f13de741dc6e70ec92f36bb27256beba", "old_mode": 33188, "old_path": "src/gn/test_with_scope.cc", "new_id": "dda4b2ada51806358ea2a36befb38ad9c59caa27", "new_mode": 33188, "new_path": "src/gn/test_with_scope.cc" }, { "type": "modify", "old_id": "de1f9671d72ff116d922ae5e4839b988e878fb3c", "old_mode": 33188, "old_path": "src/gn/test_with_scope.h", "new_id": "6292b6c36a3950699696860100984f29c8c101b9", "new_mode": 33188, "new_path": "src/gn/test_with_scope.h" } ] }