)]}'
{
  "commit": "0d00acaef051e63969f936be5dc06ff7aac7213b",
  "tree": "482a61ef335461b81a891d23936bd25388ea2a54",
  "parents": [
    "efa1e2e0a1249edaef4399bf45b535f43ea27099"
  ],
  "author": {
    "name": "Sylvain Defresne",
    "email": "sdefresne@chromium.org",
    "time": "Mon May 03 16:45:33 2021 +0200"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu May 06 10:29:31 2021 +0000"
  },
  "message": "Pass std::string_view by value\n\nAs std::string_view is a relatively small structure it can be passed\nby value. The code was using a mix of passing it either by value or\nby const reference. Settle on passing by value.\n\nRemove some unnecessary templated functions that was only overloaded\nfor `const std::string\u0026` and `const std::string_view` as the latter\nwas enough.\n\nFix IWYU by adding `#include \u003cstring_view\u003e` in all header files that\nuses std::string_view.\n\nBug: none\nChange-Id: If42ab28342e8d73f6f0543e77319fdf6380c41b5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11400\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ea4bbda5a2e2ea103039f0874549c04c6c38c89f",
      "old_mode": 33188,
      "old_path": "src/base/command_line.cc",
      "new_id": "ba9a6b06df0dddde3c015baf0b49938aee48255c",
      "new_mode": 33188,
      "new_path": "src/base/command_line.cc"
    },
    {
      "type": "modify",
      "old_id": "46c1fcc588b594f23d9ef387c856b3facc476f56",
      "old_mode": 33188,
      "old_path": "src/base/command_line.h",
      "new_id": "3a4434666cc0301a67b1623bb598a95ff941cb96",
      "new_mode": 33188,
      "new_path": "src/base/command_line.h"
    },
    {
      "type": "modify",
      "old_id": "29c9a97fc5d777bcf3bf06f753d592ad0f962f4d",
      "old_mode": 33188,
      "old_path": "src/base/containers/span.h",
      "new_id": "4af83b44bcb4fbd7c98b8758b5fcd121181c00d2",
      "new_mode": 33188,
      "new_path": "src/base/containers/span.h"
    },
    {
      "type": "modify",
      "old_id": "4fcab552f5b3876a5b58e8f0de5e87a924c57dd5",
      "old_mode": 33188,
      "old_path": "src/base/md5.cc",
      "new_id": "54684e95a42b38fc7bde8912dd2bb0660249b63a",
      "new_mode": 33188,
      "new_path": "src/base/md5.cc"
    },
    {
      "type": "modify",
      "old_id": "d25b2fcd69314511a1ba4c96426b471aff8a7dc4",
      "old_mode": 33188,
      "old_path": "src/base/md5.h",
      "new_id": "b00165cc79c7d697b4126810b7f29e9433254eb2",
      "new_mode": 33188,
      "new_path": "src/base/md5.h"
    },
    {
      "type": "modify",
      "old_id": "ee55a244dfcbe7f6c7bbfe8ad88a05e9001fd3c1",
      "old_mode": 33188,
      "old_path": "src/base/strings/utf_offset_string_conversions.cc",
      "new_id": "6f2aaf4e10f29ece6649d2353ca4b839f43be187",
      "new_mode": 33188,
      "new_path": "src/base/strings/utf_offset_string_conversions.cc"
    },
    {
      "type": "modify",
      "old_id": "8d6c5e80a8cf8892c6d76e9e5350671701a6a23f",
      "old_mode": 33188,
      "old_path": "src/base/strings/utf_offset_string_conversions.h",
      "new_id": "0562e018b901a1560663cf3d32a44cb10885260d",
      "new_mode": 33188,
      "new_path": "src/base/strings/utf_offset_string_conversions.h"
    },
    {
      "type": "modify",
      "old_id": "992d48f18dd3dd12dbb10eb81ca7023ea4bf7a90",
      "old_mode": 33188,
      "old_path": "src/gn/args.h",
      "new_id": "24e83083141ad999dca48f7e355f0f7bf61f7a9b",
      "new_mode": 33188,
      "new_path": "src/gn/args.h"
    },
    {
      "type": "modify",
      "old_id": "f8626e17ab3b6be72ab972fd4e26d4a138ef14ba",
      "old_mode": 33188,
      "old_path": "src/gn/c_include_iterator.cc",
      "new_id": "9fcc6be3bde62516ef90cfeb1bf04b65a28314dd",
      "new_mode": 33188,
      "new_path": "src/gn/c_include_iterator.cc"
    },
    {
      "type": "modify",
      "old_id": "14ca3482194cb543e392390190ed478252245304",
      "old_mode": 33188,
      "old_path": "src/gn/command_args.cc",
      "new_id": "e74c59862eeaac0e41e8a8b71ca7527a6e03ffc1",
      "new_mode": 33188,
      "new_path": "src/gn/command_args.cc"
    },
    {
      "type": "modify",
      "old_id": "b614a9ca6486f339efa23d49abb7c96fe4107700",
      "old_mode": 33188,
      "old_path": "src/gn/create_bundle_target_generator.cc",
      "new_id": "0a3d7cf4ea4d804e7d7382571cdde794ddc53485",
      "new_mode": 33188,
      "new_path": "src/gn/create_bundle_target_generator.cc"
    },
    {
      "type": "modify",
      "old_id": "6f13fb45b5c6efafb43f1ebbbd10f530e0d34308",
      "old_mode": 33188,
      "old_path": "src/gn/create_bundle_target_generator.h",
      "new_id": "6a0971a3d37322a2d203759d86fb7de73fc766e7",
      "new_mode": 33188,
      "new_path": "src/gn/create_bundle_target_generator.h"
    },
    {
      "type": "modify",
      "old_id": "301ee8d6ed52c45f425058e9f5f2deecca5e941c",
      "old_mode": 33188,
      "old_path": "src/gn/err.cc",
      "new_id": "68cb046e6c08951aed81eaf8637aa0066dae7df5",
      "new_mode": 33188,
      "new_path": "src/gn/err.cc"
    },
    {
      "type": "modify",
      "old_id": "3c8dc3f498ac2dab21a25947422384d12e71f478",
      "old_mode": 33188,
      "old_path": "src/gn/escape.cc",
      "new_id": "687c92ac0652a0a34d09ce920f12b7d4ae72a67e",
      "new_mode": 33188,
      "new_path": "src/gn/escape.cc"
    },
    {
      "type": "modify",
      "old_id": "31f972edb4d4373ac13995b5f547721b4eeba621",
      "old_mode": 33188,
      "old_path": "src/gn/escape.h",
      "new_id": "57a723fede7bf674d5c3bcd665cf095032f5d348",
      "new_mode": 33188,
      "new_path": "src/gn/escape.h"
    },
    {
      "type": "modify",
      "old_id": "0ae50619e596a56f035c3b19c0085030fa41b9b4",
      "old_mode": 33188,
      "old_path": "src/gn/file_writer.h",
      "new_id": "9b7a01f39adbd58762d5ad0eb928288a2a719168",
      "new_mode": 33188,
      "new_path": "src/gn/file_writer.h"
    },
    {
      "type": "modify",
      "old_id": "9eb713b8b8eb5ae27a158a901daf7be132344243",
      "old_mode": 33188,
      "old_path": "src/gn/filesystem_utils.cc",
      "new_id": "4906d56c8982de5d24ac205da11705b4d25fe5af",
      "new_mode": 33188,
      "new_path": "src/gn/filesystem_utils.cc"
    },
    {
      "type": "modify",
      "old_id": "830478a5fcd46cd21904d3cc55e45c5343aa8563",
      "old_mode": 33188,
      "old_path": "src/gn/filesystem_utils.h",
      "new_id": "9f21cffa6b4dd887d3aac068287d3c1aebed4d28",
      "new_mode": 33188,
      "new_path": "src/gn/filesystem_utils.h"
    },
    {
      "type": "modify",
      "old_id": "2506f19420d404477d575fa1a0882624ded3623a",
      "old_mode": 33188,
      "old_path": "src/gn/generated_file_target_generator.cc",
      "new_id": "0a9212273278951662429969c9cb747a385165cd",
      "new_mode": 33188,
      "new_path": "src/gn/generated_file_target_generator.cc"
    },
    {
      "type": "modify",
      "old_id": "dcc481408b3c17e3b64585bcbacdd75cc733d592",
      "old_mode": 33188,
      "old_path": "src/gn/generated_file_target_generator.h",
      "new_id": "c10c6006533d36e1259de2ebba660e55e434307e",
      "new_mode": 33188,
      "new_path": "src/gn/generated_file_target_generator.h"
    },
    {
      "type": "modify",
      "old_id": "e82a939b5e68fdd26fd16f8484a6bd206b128e80",
      "old_mode": 33188,
      "old_path": "src/gn/input_conversion.cc",
      "new_id": "73e8dcc00f28c2bc1d4a5b0fe463726a83e7378e",
      "new_mode": 33188,
      "new_path": "src/gn/input_conversion.cc"
    },
    {
      "type": "modify",
      "old_id": "173c3d5bf1bcc534e90c0f0282aa861e72cda919",
      "old_mode": 33188,
      "old_path": "src/gn/label.cc",
      "new_id": "c78b00e509e5cf2df31160ce2c6d58b686ff8699",
      "new_mode": 33188,
      "new_path": "src/gn/label.cc"
    },
    {
      "type": "modify",
      "old_id": "dc9813b439f9c0be97623fcdf704dc3eeb2fed53",
      "old_mode": 33188,
      "old_path": "src/gn/label.h",
      "new_id": "1458fcce297c21fd420fa047b4fdb177a2b4660a",
      "new_mode": 33188,
      "new_path": "src/gn/label.h"
    },
    {
      "type": "modify",
      "old_id": "35235e5c26e5a868c819fab86de7654227c13ac3",
      "old_mode": 33188,
      "old_path": "src/gn/label_pattern.cc",
      "new_id": "9a21829568bd513407fd34169b151657f55d8ffb",
      "new_mode": 33188,
      "new_path": "src/gn/label_pattern.cc"
    },
    {
      "type": "modify",
      "old_id": "f40750eea0ced24084d9cd65e76cbf8f134cf5fe",
      "old_mode": 33188,
      "old_path": "src/gn/label_pattern.h",
      "new_id": "fbb11fa1539b384244113e5c703853b7e1511895",
      "new_mode": 33188,
      "new_path": "src/gn/label_pattern.h"
    },
    {
      "type": "modify",
      "old_id": "cbb67f14e76933668596a04519f57bdcba219ae1",
      "old_mode": 33188,
      "old_path": "src/gn/lib_file.cc",
      "new_id": "6723a187ef8567ea5cdb0b93bff99485a161cd34",
      "new_mode": 33188,
      "new_path": "src/gn/lib_file.cc"
    },
    {
      "type": "modify",
      "old_id": "47952f8e14d6e907ebbeee52839b14d5990cf5d5",
      "old_mode": 33188,
      "old_path": "src/gn/lib_file.h",
      "new_id": "575a9e9680f34a88dbb84fbc8a928c614e40de33",
      "new_mode": 33188,
      "new_path": "src/gn/lib_file.h"
    },
    {
      "type": "modify",
      "old_id": "e7852aaa3c21367305e6344b3a0be0c4d30517cc",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_build_writer.cc",
      "new_id": "28e2fa643d731c056994f2b2fd9391e0123c809e",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_build_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "9f41a38d33c8e051e3cfc693fc5b792b117cf9e4",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_build_writer.h",
      "new_id": "b5e9e6ad18846b20a0b5a3110e130523fb4a08c4",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_build_writer.h"
    },
    {
      "type": "modify",
      "old_id": "d9d30bc29d90a8df445baa92b214c12d9ff6f704",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_target_command_util.h",
      "new_id": "00f9a77b0e07d84acb421a9f0cf3874cddd69306",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_target_command_util.h"
    },
    {
      "type": "modify",
      "old_id": "9ab28b5d2d2beef873623379e9d9d474a749dd8c",
      "old_mode": 33188,
      "old_path": "src/gn/parse_tree.cc",
      "new_id": "83452d0f18c662f0472fd427fa5188f5c3d30ebb",
      "new_mode": 33188,
      "new_path": "src/gn/parse_tree.cc"
    },
    {
      "type": "modify",
      "old_id": "9ffacc20798d4e6c6356c1009106f3e32144f263",
      "old_mode": 33188,
      "old_path": "src/gn/parse_tree.h",
      "new_id": "57d82e3a9d9ba3d75b9548fc9fc75c75df85a274",
      "new_mode": 33188,
      "new_path": "src/gn/parse_tree.h"
    },
    {
      "type": "modify",
      "old_id": "c89e061c3d4b94c040d2cf73193c553a008eeba7",
      "old_mode": 33188,
      "old_path": "src/gn/path_output.cc",
      "new_id": "d2886d7ebfb481ef723c562e51be8bdab07f6624",
      "new_mode": 33188,
      "new_path": "src/gn/path_output.cc"
    },
    {
      "type": "modify",
      "old_id": "729ba9864fa283f0000df3126496858b1eb06b95",
      "old_mode": 33188,
      "old_path": "src/gn/path_output.h",
      "new_id": "e04d236f8f0563b7b14d26878d5a2a2ec53ebb0e",
      "new_mode": 33188,
      "new_path": "src/gn/path_output.h"
    },
    {
      "type": "modify",
      "old_id": "117442fa10b511ff8e46976ecb25ac923a54e460",
      "old_mode": 33188,
      "old_path": "src/gn/rust_project_writer.cc",
      "new_id": "ee62479a554635d78cc867b1aa8d853794365b29",
      "new_mode": 33188,
      "new_path": "src/gn/rust_project_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "0020e2cfce0f08d0eef6012a07334814ce23739d",
      "old_mode": 33188,
      "old_path": "src/gn/rust_project_writer_helpers.h",
      "new_id": "a63ded1f520c1c8dca4345eb87ac14c73f0b1d96",
      "new_mode": 33188,
      "new_path": "src/gn/rust_project_writer_helpers.h"
    },
    {
      "type": "modify",
      "old_id": "6a4fdf7bf910d2b814841b61bac2486507aa1c5c",
      "old_mode": 33188,
      "old_path": "src/gn/rust_tool.h",
      "new_id": "8eec3774669544f63ae5323f0f01d8a31ef9088f",
      "new_mode": 33188,
      "new_path": "src/gn/rust_tool.h"
    },
    {
      "type": "modify",
      "old_id": "7e92766aa962ce48c5e39b368221edaa34e03295",
      "old_mode": 33188,
      "old_path": "src/gn/scope.cc",
      "new_id": "05b09957ca96da87aaec18a0be850e54a4838f5a",
      "new_mode": 33188,
      "new_path": "src/gn/scope.cc"
    },
    {
      "type": "modify",
      "old_id": "e6a2f5fa040c4c750dbfcf1682724e28d2115207",
      "old_mode": 33188,
      "old_path": "src/gn/scope.h",
      "new_id": "341cefa20a9b17b9625e30396378599fdc771676",
      "new_mode": 33188,
      "new_path": "src/gn/scope.h"
    },
    {
      "type": "modify",
      "old_id": "3110a8f75b343a91fa174d93f4ad42e7a23f3cab",
      "old_mode": 33188,
      "old_path": "src/gn/scope_per_file_provider.cc",
      "new_id": "9332c40e899664eb8f65c1dcf8471e60e6d5732c",
      "new_mode": 33188,
      "new_path": "src/gn/scope_per_file_provider.cc"
    },
    {
      "type": "modify",
      "old_id": "228bac3cd694c42b3bb9647dd5419bad5fb6f9e0",
      "old_mode": 33188,
      "old_path": "src/gn/scope_per_file_provider.h",
      "new_id": "3daa4fbbea8a0c6f3a6df5edd923ba7834d32b22",
      "new_mode": 33188,
      "new_path": "src/gn/scope_per_file_provider.h"
    },
    {
      "type": "modify",
      "old_id": "ce92cf22c78fd6bbdd85b816fde641c5944b04b0",
      "old_mode": 33188,
      "old_path": "src/gn/source_dir.cc",
      "new_id": "f34a637659c416e6fabcfa415785dc0a717ae18d",
      "new_mode": 33188,
      "new_path": "src/gn/source_dir.cc"
    },
    {
      "type": "modify",
      "old_id": "5c436f47bdca82ff055e08af7906be14b699bda6",
      "old_mode": 33188,
      "old_path": "src/gn/source_dir.h",
      "new_id": "d8b3c2852ae2a0ab4ac6e78c2dc97be29ca46245",
      "new_mode": 33188,
      "new_path": "src/gn/source_dir.h"
    },
    {
      "type": "modify",
      "old_id": "fe1ef7382cdec80f504dd76d809805c32c514418",
      "old_mode": 33188,
      "old_path": "src/gn/string_atom.cc",
      "new_id": "b4cd9f797851ea919c3831628270c34ba9b69fc7",
      "new_mode": 33188,
      "new_path": "src/gn/string_atom.cc"
    },
    {
      "type": "modify",
      "old_id": "29d4e41012597aa205c48d4c5b4eca1d3f80670b",
      "old_mode": 33188,
      "old_path": "src/gn/string_atom.h",
      "new_id": "541399ea01842057a340a44a1163656e8059858d",
      "new_mode": 33188,
      "new_path": "src/gn/string_atom.h"
    },
    {
      "type": "modify",
      "old_id": "d2a42c9cf378a73d38068939ac3df28df634cb3c",
      "old_mode": 33188,
      "old_path": "src/gn/string_output_buffer.h",
      "new_id": "5e89250d9198dca28e0aa35d2c300f9f496fafe7",
      "new_mode": 33188,
      "new_path": "src/gn/string_output_buffer.h"
    },
    {
      "type": "modify",
      "old_id": "b785e759e9ad6c630f672f250863668b6fdc3156",
      "old_mode": 33188,
      "old_path": "src/gn/string_utils.cc",
      "new_id": "bff9e8f47f0305253b7c448f2645e1ba46752679",
      "new_mode": 33188,
      "new_path": "src/gn/string_utils.cc"
    },
    {
      "type": "modify",
      "old_id": "a98a4857edd0fd444e23e3ff467d44d04364a66a",
      "old_mode": 33188,
      "old_path": "src/gn/string_utils.h",
      "new_id": "4b3a69c54568bd956d4ddeb0f22f370036bf186d",
      "new_mode": 33188,
      "new_path": "src/gn/string_utils.h"
    },
    {
      "type": "modify",
      "old_id": "3af9c48f36fd2ddf31883761e9539e3b6c883e36",
      "old_mode": 33188,
      "old_path": "src/gn/token.cc",
      "new_id": "ea5139f2a6912db10fe686da1dc6e977d17829f9",
      "new_mode": 33188,
      "new_path": "src/gn/token.cc"
    },
    {
      "type": "modify",
      "old_id": "a11807a47d8a0a65deb8b56e28149c1f1649da5e",
      "old_mode": 33188,
      "old_path": "src/gn/token.h",
      "new_id": "6a908723343d8e2a7c978cfbfd8e8457eabf868a",
      "new_mode": 33188,
      "new_path": "src/gn/token.h"
    },
    {
      "type": "modify",
      "old_id": "93a64259de6f2bacbc2fc4114c2c1dcde539f286",
      "old_mode": 33188,
      "old_path": "src/gn/tokenizer.cc",
      "new_id": "a2f0034228031294cece3de3b15bc06f0a0dab3f",
      "new_mode": 33188,
      "new_path": "src/gn/tokenizer.cc"
    },
    {
      "type": "modify",
      "old_id": "d4b347bdbda892c3e1a8fadd4cf1875d4e38a2e8",
      "old_mode": 33188,
      "old_path": "src/gn/tokenizer.h",
      "new_id": "0af3a36ac793f77019a73d10f52929af067da1eb",
      "new_mode": 33188,
      "new_path": "src/gn/tokenizer.h"
    },
    {
      "type": "modify",
      "old_id": "eb99a2719faa1eb9049a734084a84dcb591d2889",
      "old_mode": 33188,
      "old_path": "src/gn/visibility.cc",
      "new_id": "8fb5e7f84891af8350bfc0d2c237e1a1f1867840",
      "new_mode": 33188,
      "new_path": "src/gn/visibility.cc"
    },
    {
      "type": "modify",
      "old_id": "fc1673138aad2f23f8c743b1f8647d406a62639e",
      "old_mode": 33188,
      "old_path": "src/gn/visibility.h",
      "new_id": "f0ebcf541d1d1106c5df6fcd779f62aa498b599b",
      "new_mode": 33188,
      "new_path": "src/gn/visibility.h"
    },
    {
      "type": "modify",
      "old_id": "0761b4f346c2150e4306d9f4004ea94e23e3e173",
      "old_mode": 33188,
      "old_path": "src/gn/xcode_object.cc",
      "new_id": "1d08f22bc1f81a9db25be6ddd0a22642391b79b3",
      "new_mode": 33188,
      "new_path": "src/gn/xcode_object.cc"
    },
    {
      "type": "modify",
      "old_id": "8525057b5e08c567b8d4f824bd5f26956e8978ee",
      "old_mode": 33188,
      "old_path": "src/gn/xml_element_writer.cc",
      "new_id": "f88891579a7485ae08e7952492bf4da0fd3798a1",
      "new_mode": 33188,
      "new_path": "src/gn/xml_element_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "9040d16b8e0e39852104fc8f75ee5340330e1b27",
      "old_mode": 33188,
      "old_path": "src/gn/xml_element_writer.h",
      "new_id": "6229f88944d1181e7af77e1104e9f11a57597963",
      "new_mode": 33188,
      "new_path": "src/gn/xml_element_writer.h"
    }
  ]
}