commit 0ddc5b8f8695734db98653d7dac1d6953604c066
author brettw <brettw@chromium.org> Mon Jan 09 16:25:19 2017 -0800
committer Commit bot <commit-bot@chromium.org> Tue Jan 10 00:25:19 2017 +0000
tree 30a9d23b3b453946f230a82874cbba6af3c539bb
parent 23db84eaf700b6cada65a87b12ea2f158c0d237d

Fix a GN race condition.

The loader maintains a reference count on the "pending work". But the
Setup object was starting the load before incrementing this reference count.
It the loader happened to load anything on the background thread before the
main thread could increment the reference count, GN would think there is no
work left and exit early.

There is another possible race condition between defining items and doing
work on the thread pool can cause the build to be marked complete before
everything is actually done. The race condition is described in more detail
in the added comment in setup.cc.

BUG=674213

Review-Url: https://codereview.chromium.org/2617253002
Cr-Original-Commit-Position: refs/heads/master@{#442416}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 717182cd794aae4577fbae651a88e3ba6d973dc8