tree 6013f42b7218cccbea53fcf6d8725ca718b8831d
parent d1ee470c695607b9b5554cdf5925d32564e5e2c8
author Takuto Ikuta <tikuta@google.com> 1753950012 -0700
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1753969238 -0700

Revert "Allow newline in string literal"

This reverts commit acfe5fde8c5475a9a83bd55f3f222a6dbbcbd0ae.

Reason for revert: This change is being reverted due to concerns about
introducing confusing and less helpful error messages.

Allowing newlines in regular string literals can lead to misleading
error messages when, for example, a closing quote is forgotten. This
would make debugging more difficult.

The utility of multi-line strings is also limited without additional
features, such as special handling for leading whitespace. While the
idea has merit, the change in its current state is not robust enough and
would require better error handling to be a net positive.

See discussion in
https://gn-review.git.corp.google.com/c/gn/+/19361/comments/f029b489_c14ec6de
for more details.

Original change's description:
> Allow newline in string literal
>
> It seems fine to have newline in string literal and it is convinient if
> we want to have multiline string literal in someplaces e.g. print,
> assert.
>
> Change-Id: Ied7845ad6b6f6548035bd545e5c21dc837769ee7
> Reviewed-on: https://gn-review.googlesource.com/c/gn/+/19361
> Commit-Queue: David Turner <digit@google.com>
> Reviewed-by: David Turner <digit@google.com>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ic28abb3a3c005ca83de4805a1a9fc79b0b84fba9
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/19540
Reviewed-by: Nico Weber <thakis@google.com>
Commit-Queue: Takuto Ikuta <tikuta@google.com>