)]}'
{
  "commit": "12ca980852f2dcba1e155ae215740d0d9a56cf7f",
  "tree": "ccb7450c7c9045cb53b4d451a007f43a829de0c3",
  "parents": [
    "4aa7dc7da99d12dc3207cff436c3acf968c24fd4"
  ],
  "author": {
    "name": "Joey Scarr",
    "email": "jsca@google.com",
    "time": "Thu Jun 07 00:23:51 2018 +0000"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Jun 07 00:23:51 2018 +0000"
  },
  "message": "Fix quoting when writing defines on Windows.\n\nFor the following string-valued define:\n defines \u003d [ \"CR_CLANG_REVISION\u003d\\\"$clang_revision\\\"\" ]\nthis was outputting the following on Windows:\n -D\"CR_CLANG_REVISION\u003d\\\"332838-1\\\"\"\nThe Windows shell can\u0027t handle the extra quotes, and so the following\nmacro was being written:\n #define \"CR_CLANG_REVISION \"332838-1\"\"\nThis change moves the first quote to before the -D, allowing Windows to\ncorrectly handle the define parameter.\n\nR\u003dbrettw@chromium.org\n\nBug: 396230\nChange-Id: I4f6f70acf775577ff9b3077eba9ebf7f8d002da1\nReviewed-on: https://chromium-review.googlesource.com/1071274\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Joey Scarr \u003cjsca@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#565117}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 44054a1e89063bf0063cfc4d72632c2f1589ee8b",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1711ad237849f118bd7359f0b89eadf325950290",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_binary_target_writer.cc",
      "new_id": "fb2fcf892b91881a8e3fe343b57b1088fb9eb1c3",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_binary_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "20239b05373145e18d10831e80c42892de1dd221",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_binary_target_writer_unittest.cc",
      "new_id": "acbd88b9966745b3d594283b8736f910d968703a",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_binary_target_writer_unittest.cc"
    }
  ]
}
