tree fd69e5e5f0dfba483daf3387a64042ba9b9b98f2
parent 3281c6697cbb7d5488f5e650dfce60b1999bcfab
author David Turner <digit@google.com> 1603133212 +0000
committer Commit Bot <commit-bot@chromium.org> 1603133231 +0000

Revert "gn recipe: Link GN with rpmalloc to speed it up."

This reverts commit 4323e7015d8a7f74208962dd11f2d1065ae8aa15.

Reason for revert: https://bugs.chromium.org/p/gn/issues/detail?id=208

Original change's description:
> gn recipe: Link GN with rpmalloc to speed it up.
>
> This CL changes the GN recipe to link the executable with the
> rpmalloc allocator from https://github.com/mjansson/rpmalloc
>
> This speeds up the 'gn gen' operation of both Chromium and Fuchsia
> operations by 28% and 12% respectively [1], and has slightly better
> performance than using tcmalloc from gperftools in the Fuchsia case.
>
> Note that:
>
> - The sources are grabbed directly from github.com, but it might be
>   desirable to use a Chromium or Fuchsia supported mirror instead.
>
> - Only Linux has been tested so far, so only this platform enables
>   this build mode.
>
> [1] Median measurements from 10 runs of 'gn gen' using the default
>     Linux allocator (glibc), gperftools' tcmalloc, and rpmalloc:
>
>   Fuchsia:
>       glibc (default):  9917 ms
>       gperftools:       7858 ms  (26% faster)
>       rpmalloc:         7752 ms  (28% faster)
>
>   Chromium:
>       glibc (default):  4742 ms
>       gperftools:       4186 ms  (13% faster)
>       rpmalloc:         4235 ms  (12% faster)
>
> Change-Id: Ia52134ef602f546d6e8b33bef0146c620d214b58
> Reviewed-on: https://gn-review.googlesource.com/c/gn/+/9920
> Commit-Queue: David Turner <digit@google.com>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Petr Hosek <phosek@google.com>

TBR=phosek@google.com,scottmg@chromium.org,pylaligand@google.com,digit@google.com

Change-Id: I654d4646dae1d75d0aa2c110dbd7128dc0dd0911
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/10360
Reviewed-by: David Turner <digit@google.com>
Commit-Queue: David Turner <digit@google.com>