)]}' { "commit": "170c2dba1e0c0299fe8c6a441caf2f2352a42ae0", "tree": "4bc7ca805337c355031db1c258acceb363612a17", "parents": [ "7d803996740ccd587c54062750cbe04dfbc3c423" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jun 11 17:29:59 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jun 18 22:19:30 2021 +0000" }, "message": "Replace OrderedSet\u003c\u003e instances with UniqueVector\u003c\u003e.\n\nThe OrderedSet\u003c\u003e template has a misleading name, because its\nsemantics are not those of an ordered set of items, but match\ncompletely those of UniqueVector\u003c\u003e. The latter is also slightly\nfaster and uses less memory.\n\nThis CL replaces all instances of OrderedSet\u003c\u003e with UniqueVector\u003c\u003e\nones, and removes the template definition from the source tree.\n\nProfiling shows no noticeable difference in performance or memory usage\nwith the Chrome and Fuchsia \"gn gen\" operations.\n\nChange-Id: Ie9b8ecfc0724d07129f69c68db5e1205b49f3970\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11825\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "325735ab290356aec8d5b1754b8b55c9a456d518", "old_mode": 33188, "old_path": "src/gn/desc_builder.cc", "new_id": "2b4ac52825a217022259529224073910ba3a8692", "new_mode": 33188, "new_path": "src/gn/desc_builder.cc" }, { "type": "modify", "old_id": "3ad4320f4f04644977e99757567d18864b0750b5", "old_mode": 33188, "old_path": "src/gn/ninja_binary_target_writer.cc", "new_id": "50e3e2918467e40b32049f12f72dc07f51d2d3f1", "new_mode": 33188, "new_path": "src/gn/ninja_binary_target_writer.cc" }, { "type": "modify", "old_id": "c1432b29d29f9ef7cad40ddf836cd3a2e17344ed", "old_mode": 33188, "old_path": "src/gn/ninja_c_binary_target_writer.cc", "new_id": "cd76a1684d8efe8036cfacfe56b01d76da54cd9e", "new_mode": 33188, "new_path": "src/gn/ninja_c_binary_target_writer.cc" }, { "type": "delete", "old_id": "fda4e121f5c43c32efc5838ad12987d78e87db1c", "old_mode": 33188, "old_path": "src/gn/ordered_set.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "cee2ed2ce968d20fa839df9f538424be556586cf", "old_mode": 33188, "old_path": "src/gn/target.cc", "new_id": "bd3fb5851bd531e7ffc8135673858add3fdf411c", "new_mode": 33188, "new_path": "src/gn/target.cc" }, { "type": "modify", "old_id": "15fb63526fea76983210e1914eb31ea7c7158642", "old_mode": 33188, "old_path": "src/gn/target.h", "new_id": "96f80f2061ea0c5eb79f3b737a1e52408a64206b", "new_mode": 33188, "new_path": "src/gn/target.h" }, { "type": "modify", "old_id": "91bf726c5a731447d3f9a631ffd7eb3240ecdd9a", "old_mode": 33188, "old_path": "src/gn/unique_vector.h", "new_id": "821f55ae71eee5d170de37869c025a65b8be7ed2", "new_mode": 33188, "new_path": "src/gn/unique_vector.h" } ] }