)]}' { "commit": "1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41", "tree": "83bcf3565ba08c0fe465ee0975676c7383321ca0", "parents": [ "a4d67be044b42963de801001e7146f9657c7fad4" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Nov 10 13:58:32 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 10 16:29:39 2022 +0000" }, "message": "[xcode] Refer to target by their long name in generate Xcode project\n\nAccording to NinjaBuildWriter::WritePhonyAndAllRules() documentation,\ngn only generate a phony target with the short target name if it is\neither an executable or unambiguous.\n\nRecently a \"chrome\" target was added in a third-party repository\nwhich broke the compilation of Chrome on iOS from the genrated Xcode\nproject since the \"chrome\" name was no longer unambiguous. Since the\ntarget is a bundle and not an executable, the phony target with the\nshort name was not created.\n\nChange the Xcode generator to use the long name for the target for\nwhich the phony target is always generated. User don\u0027t need to care\nabout collision when using Xcode to build.\n\nBug: chromium/1383100\nChange-Id: I5e1b43f4e675cc1967744e80194eb7fe7f8ae310\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14840\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Justin Cohen \u003cjustincohen@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "8216aa40ae2d04c92f9d7ff57aaa176409874c5b", "old_mode": 33188, "old_path": "src/gn/xcode_writer.cc", "new_id": "2673d3c1859ce872b12500a103356800db9c274c", "new_mode": 33188, "new_path": "src/gn/xcode_writer.cc" } ] }