|author||Haowei Wu <email@example.com>||Fri Apr 19 16:52:55 2019 -0700|
|committer||Commit Bot <firstname.lastname@example.org>||Mon Apr 22 18:27:25 2019 +0000|
Canonicalize metadata walk_keys list before comaparing. This change patches Target::GetMetadata function to canonicalize walk_keys before comparing with deps. Bug: crbug.com/gn/68 Test: Local and CQ Change-Id: I15152dfa01f76538fdfb95a839b62134006d3195 Reviewed-on: https://gn-review.googlesource.com/c/gn/+/4680 Reviewed-by: Julie Hockett <email@example.com> Commit-Queue: Haowei Wu <firstname.lastname@example.org>
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.