| commit | 27ef6b4e60e9885a3e1fc5c85b0bd41b82971466 | [log] [tgz] |
|---|---|---|
| author | Tom Anderson <thomasanderson@chromium.org> | Mon Aug 13 12:18:19 2018 -0700 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Aug 13 20:48:14 2018 +0000 |
| tree | f26d90aa899b76fda3fed0bcc605351db2e01790 | |
| parent | f8f395ac112b2666624f311e18079a05e4fd4a2b [diff] |
Fix gn_unittests Scope::KeyValueMap used to be a std::unordered_map, which was confusing the newly added output conversion unittests that uses string comparison to check if two values are the same. The fact that the outputs were unordered means that, depending on the version of the C++ library used, a value might convert to "a=0\nb=1" or "b=1\na=0". This CL makes Scope::KeyValueMap an ordered map instead. R=brettw@google.com CC=juliehockett@google.com Change-Id: Ia3dd1b6a01759f94d1edc96c0bd2a115f743c8c7 Reviewed-on: https://gn-review.googlesource.com/2663 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org>
GN is a meta-build system that generates build files for Ninja.
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out
On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.
GN uses Gerrit for code review. The short version of how to patch is:
... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git push origin HEAD:refs/for/master # This uploads for review.
When revising a change, use:
git commit --amend git push origin HEAD:refs/for/master
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.