tree 9dc64a9c415bbae6199804f7011f52e30b9100c9
parent 6966efb0f6ff0f80b1a6bc5ee6ac2f343ecf3523
author Ian McKellar <ianloic@google.com> 1607977156 -0800
committer Commit Bot <commit-bot@chromium.org> 1607979814 +0000

Fix crash in invalid scope subscript access

When accessing a missing scope member through the string subscript
syntax (scope["member"]) the error check didn't actually return
resulting in a NULL dereference. This fixes that and adds tests.

It also fixes some of the parse tree unit tests which weren't correctly
resetting their error values.

Bug: 209
Change-Id: Ida1415b63ce1bca1d479c732126d5336eec13fc9
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/10860
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>