tree 2d1448c7f9a4503894f1fbfeb1c8a777fba2a0cf
parent ed7fee04cb30b96ed40ef188acfad5417349e399
author Henrique Ferreiro <hferreiro@igalia.com> 1793707484 +0100
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1793729222 -0800

Fix how the regeneration command writes gn's own paths

GetSelfInvocationCommandLine() escapes the switches it copies from the
current command line, but not the gn executable, --root or --dotfile,
which it writes itself. A space or "$" in any of those paths broke
regeneration, since Ninja expanded "$" and the shell split on spaces.
Escape them like every other switch.

Also only write the gn executable and --dotfile relative to the build
directory if they're inside the source root or the build directory,
since those are the places where relative paths keep working even if
they're moved.

For that, FilePath::IsParent() has to match roots written with different
separators on Windows: the source root always uses '/', but the paths
compared with it may not, and "C:/src" wasn't considered a parent of
"C:\src\list.txt". Port the root comparison that
https://crrev.com/c/8674581 added to AppendRelativePath(), which treats
roots made of the same number of separators as equal.

This is a precursor to https://gn-review.googlesource.com/c/gn/+/18220,
which handles --runtime-deps-list-file the same way.

Change-Id: I107aabe2d8a9f1b67c62792bb3ff2ae92973d5a8
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/28400
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@google.com>
Commit-Queue: Andrew Grieve <agrieve@google.com>