tree 9ec4090ac10f9d944c1d5c6f1c3aea22945cab08
parent fd6cae41bd7d5d255dc2fb96004a8bf74ac9d972
author Evangelos Foutras <evangelos@foutrelis.com> 1654691989 +0300
committer Commit Bot <commit-bot@chromium.org> 1654699130 +0000

Simplify source_dir_path substring extraction

Instead of checking if 'source_dir_path' is longer than 'build_dir'
before using the latter's length as an index into the first string,
switch to calling the subsrt() method of the former. This correctly
handles the case of both strings having the same length while being
clearer about its intended function.

Bug: 293
Fixes: fd6cae41bd7d ("Avoid out-of-bounds string indexing")
Change-Id: I46d29efb579b70eec47e32004347ebfccc56430e
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/14120
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>