)]}'
{
  "commit": "2f5f34aced5f9721cda3eef963f4f7d231a0ae99",
  "tree": "5805ad0dd0fffa6d6e46ae5f97d4924d0840751e",
  "parents": [
    "7015f8e0e533b406919ad5b6edf5ec3605d605f1"
  ],
  "author": {
    "name": "Andrew Grieve",
    "email": "agrieve@google.com",
    "time": "Tue Nov 10 13:05:03 2026 -0500"
  },
  "committer": {
    "name": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Nov 12 02:39:38 2026 -0800"
  },
  "message": "Delay the whole Ninja writer of delayed generated_file() targets\n\ngenerated_file() targets that set collect_validations_metadata must run\ntheir metadata walk after all targets are resolved. This was done by\nhaving NinjaGeneratedFileTargetWriter report through an out-param that\nit skipped writing the file, and then writing only the file from the\npost-resolution callback.\n\nInstead, decide whether a target is delayed in\nItemResolvedAndGeneratedCallback() (which runs on the main thread), and\nrun the regular BackgroundDoWrite() for delayed targets from the\npost-resolution callback. This removes the delayed_generated_file_write\nout-param from NinjaTargetWriter::RunAndWriteFile() and\nNinjaGeneratedFileTargetWriter.\n\nThe set of delayed targets and the generated files are unchanged. This\nis in preparation for letting the Ninja build statement of a\ngenerated_file() depend on the result of its metadata walk.\n\nBug: 579603584\nChange-Id: I5f5f0940dba3c5d2e0a719dfd3d79b2e95fbd7a3\nAgent-Generated: true\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/28700\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fbb4eab07b53647e4a6cbb8302dd7cdff0082f7d",
      "old_mode": 33188,
      "old_path": "src/gn/builder_record.h",
      "new_id": "26bdd9c3de78ee7c5b720190a4ad7b46fa356556",
      "new_mode": 33188,
      "new_path": "src/gn/builder_record.h"
    },
    {
      "type": "modify",
      "old_id": "4e991c331957b697a44c7cdbb926b51481af42c0",
      "old_mode": 33188,
      "old_path": "src/gn/command_gen.cc",
      "new_id": "1d6668a131091f6fac968189740430d57e9ce3a4",
      "new_mode": 33188,
      "new_path": "src/gn/command_gen.cc"
    },
    {
      "type": "modify",
      "old_id": "cafc5eb9aab20b2f9dd1dbee3d6b47ed6ec58801",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_generated_file_target_writer.cc",
      "new_id": "7314e722d644e4b4d3f59085bc626f7962ad500f",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_generated_file_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "8dbaa435e04fe4ebfd6b2b742544179266f99698",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_generated_file_target_writer.h",
      "new_id": "1e58ffe6bad085a68ab34f77dc01dd041450442d",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_generated_file_target_writer.h"
    },
    {
      "type": "modify",
      "old_id": "8a16cf172ff5be6c11dc2cc94d3b187137745909",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_generated_file_target_writer_unittest.cc",
      "new_id": "f9bb03cdff93183748bacf0b3ad61d3df81d0c8b",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_generated_file_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "4994433db8a43113a7d3edc9d5e7e28597e5c913",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_target_writer.cc",
      "new_id": "0bdcfa54299f90a1333d387fed6255c869b09a64",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "fff7c97ae8ca25fc6ba9049c5ca0a2a24ef851b3",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_target_writer.h",
      "new_id": "4f5c0d1893c76bbfd1c38c60992a2d874720a459",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_target_writer.h"
    }
  ]
}
