tree bc02f5a877eb4348db872a71fe0d172ca98f0c8b
parent 0fefaeb1b9f7cf0ef8faf03f8e906d1449f0c714
author Peter Collingbourne <pcc@chromium.org> 1779394593 -0700
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1779849238 -0700

Reland "Fix toolchain dependencies not triggering rebuilds in Ninja"

This reverts commit 576a0ebd4cc674fb52681bd1becfd0facec8449e.

Reason for revert: Siso fix has rolled out: b/512275057

Original change's description:
> Revert "Fix toolchain dependencies not triggering rebuilds in Ninja"
>
> This reverts commit 9ece3f5254c273cb46606a6571963f931c3b012d.
>
> Reason for revert: This doesn't pass chromium CQ.
> https://chromium-review.git.corp.google.com/c/chromium/src/+/7810380
>
> Original change's description:
> > Fix toolchain dependencies not triggering rebuilds in Ninja
> >
> > GN previously emitted order-only dependencies on toolchain dependencies
> > (via the .inputdeps.stamp file). This meant that if the toolchain changed,
> > targets compiled by it were not rebuilt.
> >
> > This change modifies WriteInputDepsStampOrPhonyAndGetDep (WIDSOPAGD)
> > to return implicit dependencies separately from order-only
> > dependencies. Toolchain dependencies are now returned as implicit
> > dependencies, which ensures that Ninja triggers a rebuild when the
> > toolchain changes.
> >
> > All target writers have been updated to write the result of WIDSOPAGD as
> > either implicit or order-only dependencies. The action target writer is
> > a special case, because before this change it would write the result of
> > WIDSOPAGD as an implicit dependency, unlike all other target writers,
> > which would write it as an order-only dependency. This means that before
> > this change, all dependencies returned by WIDSOPAGD were implicit
> > dependencies for action targets. Because scripts may depend on this
> > behavior, any phony targets created by WIDSOPAGD for action targets have
> > only implicit dependencies.
> >
> > Bug: 40643484
> > Change-Id: Iae5dbf87cd67ecd5c9d0f6138f17085233c844b3
> > Reviewed-on: https://gn-review.googlesource.com/c/gn/+/22000
> > Reviewed-by: Takuto Ikuta <tikuta@google.com>
> > Commit-Queue: Peter Collingbourne <pcc@google.com>
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 40643484
> Change-Id: I8f38fc48dba7a214a6ef354d2550f91a842ca8c6
> Reviewed-on: https://gn-review.googlesource.com/c/gn/+/22520
> Commit-Queue: Takuto Ikuta <tikuta@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 40643484
Change-Id: I4e5c263c92a1e24abfaaefa7f5f0c62565b233d6
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/22860
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>