)]}'
{
  "commit": "38b33e73409630fe1954804f6cfa24684f33d584",
  "tree": "bb32a8cb2b229ccac51d1ee9b95bb1fe762ab58a",
  "parents": [
    "d6621a2feda5f553d7ac75e71af5a3802aa15f13"
  ],
  "author": {
    "name": "Dirk Pranke",
    "email": "dpranke@chromium.org",
    "time": "Wed May 16 02:58:40 2018 +0000"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Wed May 16 02:58:40 2018 +0000"
  },
  "message": "Revert \"GN: do not make indirect dependency to direct dependency\"\n\nThis reverts commit e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4.\n\nReason for revert: Looks to have broken the mac build; see crbug.com/843351 .\n\nOriginal change\u0027s description:\n\u003e GN: do not make indirect dependency to direct dependency\n\u003e \n\u003e If a target is hard dep, there is no need to have the action targets\u0027s\n\u003e recursive deps as direct dependency, because such dependency is\n\u003e transitive.\n\u003e \n\u003e This is found by pcc in gn-dev\n\u003e https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/BcrSfPQE84E\n\u003e \n\u003e With this change, generated android\u0027s toolchain.ninja size is reduced\n\u003e from 262MB to 31MB. And ninja\u0027s startup time reduced from 4.9~5.1s to\n\u003e 2.6s.\n\u003e I used args.gn same with android_n5x_swarming_rel bot.\n\u003e \n\u003e Also this patch reduced the time of `gn gen` from 9.5~10.3s to 6.8~7.2s\n\u003e on my machine.\n\u003e \n\u003e Change-Id: I0f0214d3abe74143516b263da839e98b3987fb64\n\u003e Reviewed-on: https://chromium-review.googlesource.com/1041506\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\n\u003e Commit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#557365}\n\nTBR\u003dbrettw@chromium.org,dpranke@chromium.org,pcc@chromium.org,tikuta@chromium.org\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nChange-Id: Id2bbb6fe1c8a0b10ee4b8d77de6ba83124519b68\nReviewed-on: https://chromium-review.googlesource.com/1060673\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#558946}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fa3fcf6849130fdeded2358d652faee1873b77b9",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "445a31a33379ce828e41f67d832d2b1459e0989d",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_action_target_writer_unittest.cc",
      "new_id": "1b2ddc807b590cb01aeb05d46009ac7f28784a8a",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_action_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "2bcbc8986407b7ca0ea8895e70081b74fc2d269b",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_target_writer_unittest.cc",
      "new_id": "68a59c81941172f54854c14ed27823664c322236",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "e6013e4358b11c780df5570b42b82deca3881aee",
      "old_mode": 33188,
      "old_path": "tools/gn/target.cc",
      "new_id": "15df27f52bcaedb4254a74f8033f18d44fbf9f5a",
      "new_mode": 33188,
      "new_path": "tools/gn/target.cc"
    }
  ]
}