tree bb32a8cb2b229ccac51d1ee9b95bb1fe762ab58a
parent d6621a2feda5f553d7ac75e71af5a3802aa15f13
author Dirk Pranke <dpranke@chromium.org> 1526439520 +0000
committer Commit Bot <commit-bot@chromium.org> 1526439520 +0000

Revert "GN: do not make indirect dependency to direct dependency"

This reverts commit e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4.

Reason for revert: Looks to have broken the mac build; see crbug.com/843351 .

Original change's description:
> GN: do not make indirect dependency to direct dependency
> 
> If a target is hard dep, there is no need to have the action targets's
> recursive deps as direct dependency, because such dependency is
> transitive.
> 
> This is found by pcc in gn-dev
> https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/BcrSfPQE84E
> 
> With this change, generated android's toolchain.ninja size is reduced
> from 262MB to 31MB. And ninja's startup time reduced from 4.9~5.1s to
> 2.6s.
> I used args.gn same with android_n5x_swarming_rel bot.
> 
> Also this patch reduced the time of `gn gen` from 9.5~10.3s to 6.8~7.2s
> on my machine.
> 
> Change-Id: I0f0214d3abe74143516b263da839e98b3987fb64
> Reviewed-on: https://chromium-review.googlesource.com/1041506
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557365}

TBR=brettw@chromium.org,dpranke@chromium.org,pcc@chromium.org,tikuta@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Id2bbb6fe1c8a0b10ee4b8d77de6ba83124519b68
Reviewed-on: https://chromium-review.googlesource.com/1060673
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#558946}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fa3fcf6849130fdeded2358d652faee1873b77b9