tree 780471d4f685d319010e93a9837e578117aeaa6f
parent 3968ba76ca4aadd1bc6089a0c0695faf12f4262e
author Philipp Wollermann <philwo@google.com> 1788904689 +0200
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1789561239 -0700

Header check: validate includes before building diagnostics

A header can belong to several targets. Diagnosing each candidate
during the search can build unrestricted reachability tables and
errors that are discarded when a later candidate permits the include.

Separate acceptance checks from diagnostics. First search for a target
that permits the include, checking visibility, permitted dependency
chains, include exceptions and strict checking rules. Only enter the
diagnostic pass if the include is rejected.

Chromium `gn gen --check`, medians of five round-robin rounds:
  Mac (M4 Max):    2.70 s -> 2.62 s
  GCE c4d-384:     4.22 s -> 4.08 s
  Intel 13900KS:   2.55 s -> 2.33 s

CPU time (c4d-standard-384):
  User:  31.6 s -> 28.6 s (-9%)
  Sys:   33.9 s -> 34.0 s (0%)

Heap stats:
  Allocs (count):  53.78 M -> 53.51 M (-1%)
  Heap (total):    19.78 GB -> 18.10 GB (-8%)
  Heap (peak):      3.22 GB ->  2.30 GB (-29%)

Change-Id: I8c0118801072da1d37b7da291e5c047f9abfcd29
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/26343
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Philipp Wollermann <philwo@google.com>
Reviewed-by: Matt Stark <msta@google.com>