tree 09ccb2334c5d8e2dc2ce65619c3365559fa5682d
parent ef0e05897cd0ae1dfa2d9a881e17957cf1841add
author Takuto Ikuta <tikuta@google.com> 1772675325 +0900
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1772710281 -0800

[gn] Fix Value::operator== for empty lists

The previous Copy-On-Write optimization for ValueList in
https://gn-review.googlesource.com/c/gn/+/21340 introduced a bug where
Value::operator== would return false if one list was unallocated
(list_ptr_ == nullptr) and the other was explicitly allocated but empty.

This commit removes the explicit nullptr check in operator==, allowing
empty lists to be compared properly via list_value(), and adds a unit
test to prevent regressions.

Bug: 484863025
Change-Id: I9c4bdd53fb22700ce389c9e3f8a3f12fd928c26d
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/21360
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Turner <digit@google.com>