tree 124a4d5a4c5d0a59995f011707287a82506ea331
parent 4a8016dc391553fa1644c0740cc04eaac844121e
author David 'Digit' Turner <digit@google.com> 1741006803 +0100
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1741017293 -0800

Remove obsolete debug checks.

Now that stamp files are replaced by phony Ninja targets, it is
perfectly possible for a target to not generate any Ninja rule,
so remove a DCHECK() call that caused a debug version of GN to
assert at runtime when processing a Chromium build graph.

Also remove a NOTREACHED() statement when expanding C++ specific
substitution expressions (e.g. {{cflags}} or {{include_dirs}})
that are used in action() targets, such as those expanded by
the nocompile_source_set() Chromium template. This also caused
the debug version of GN to assert at runtime.

Comparison of the generated Ninja build plan after/before this
CL shows no difference for a regular Chromium Linux/x64
configuration.

Fixed: 388100196
Change-Id: Iebc465517ea866cb35b724080058f995f885597b
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/18280
Commit-Queue: David Turner <digit@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>