)]}'
{
  "commit": "46b572ce4ceedfe57f4f84051bd7da624c98bf01",
  "tree": "e25bef8adf133eb1d39dff49da5fbe0e5b4c4487",
  "parents": [
    "69ec4fca1fa69ddadae13f9e6b7507efa0675263"
  ],
  "author": {
    "name": "Tomasz Śniatowski",
    "email": "tsniatowski@vewd.com",
    "time": "Fri Sep 03 21:47:17 2021 +0200"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Sep 06 07:19:45 2021 +0000"
  },
  "message": "Fix configs visibility not always working\n\nMake visibility apply to configs used via public_configs and\nall_dependent_configs -- and not just plain configs. Check visibility\nafter the three are merged, but before they are recursively expanded.\nBefore the fix, visibility would be silently ignored if a target used\nfor example public_configs to access a config it shouldn\u0027t see.\n\nAdd tests to check that config visibility can reject targets in all the\nthree cases, and that going through a visible helper target still works\n(which would break if visibility was checked too late).\n\nAlso, mention in the docs that configs can take a visibility flag and\nupdate reference with `out/gn --markdown help all \u003e docs/reference.md`.\n\nBug: 252, 22\nChange-Id: I941e43fecf22c0ac5aba4e674f3048272edc1d7e\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/12140\nReviewed-by: Shai Barack \u003cshayba@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Shai Barack \u003cshayba@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9104076827ec2cb46ff0d96e040ebe46fd9a8a93",
      "old_mode": 33188,
      "old_path": "docs/reference.md",
      "new_id": "8984ff42c3e088b362c6276d39928bee506c9575",
      "new_mode": 33188,
      "new_path": "docs/reference.md"
    },
    {
      "type": "modify",
      "old_id": "860d87ca8b0a444328cb2ccafc76944ec3228a8a",
      "old_mode": 33188,
      "old_path": "src/gn/config_values_extractors_unittest.cc",
      "new_id": "3db4bff900d181d87fcdbf04e928bc72bd331910",
      "new_mode": 33188,
      "new_path": "src/gn/config_values_extractors_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "6acf41ae43cfee64d8f3c00f5fe05b68496fcdaa",
      "old_mode": 33188,
      "old_path": "src/gn/functions.cc",
      "new_id": "fdb130df2b4876711ff7e975f705458e08f50060",
      "new_mode": 33188,
      "new_path": "src/gn/functions.cc"
    },
    {
      "type": "modify",
      "old_id": "f0af195da1cc7a5f0c2038a22fea96758337118e",
      "old_mode": 33188,
      "old_path": "src/gn/target.cc",
      "new_id": "44c5f14452f9b603c453f82040b8e634bfbb1431",
      "new_mode": 33188,
      "new_path": "src/gn/target.cc"
    },
    {
      "type": "modify",
      "old_id": "792c5304ea5f278df67ab1d529acc2583ce09f31",
      "old_mode": 33188,
      "old_path": "src/gn/target_unittest.cc",
      "new_id": "311cbf998500ade20641c2b1e5f2d2f57d12fc86",
      "new_mode": 33188,
      "new_path": "src/gn/target_unittest.cc"
    }
  ]
}