tree e25bef8adf133eb1d39dff49da5fbe0e5b4c4487
parent 69ec4fca1fa69ddadae13f9e6b7507efa0675263
author Tomasz Śniatowski <tsniatowski@vewd.com> 1630698437 +0200
committer Commit Bot <commit-bot@chromium.org> 1630912785 +0000

Fix configs visibility not always working

Make visibility apply to configs used via public_configs and
all_dependent_configs -- and not just plain configs. Check visibility
after the three are merged, but before they are recursively expanded.
Before the fix, visibility would be silently ignored if a target used
for example public_configs to access a config it shouldn't see.

Add tests to check that config visibility can reject targets in all the
three cases, and that going through a visible helper target still works
(which would break if visibility was checked too late).

Also, mention in the docs that configs can take a visibility flag and
update reference with `out/gn --markdown help all > docs/reference.md`.

Bug: 252, 22
Change-Id: I941e43fecf22c0ac5aba4e674f3048272edc1d7e
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/12140
Reviewed-by: Shai Barack <shayba@google.com>
Reviewed-by: Petr Hosek <phosek@google.com>
Commit-Queue: Shai Barack <shayba@google.com>