tree c11df6ece185efa051c3dedd5f4e7b7fe0f62ce9
parent 387b368dfe63fec317f8e609d90c634807f2764e
author David 'Digit' Turner <digit@google.com> 1640012010 +0100
committer Commit Bot <commit-bot@chromium.org> 1641490114 +0000

Simplify InheritedLibraries

This CL simplifies the implementation of InheritedLibraries
to use a UniqueVector<const Target*> as well as a parallel
vector of booleans (for the public flags). This doesn't
change the semantics of this type.

Combined with the previous CL, measurements show that this
saves about 10% of 'gn gen' time, and 8% of peak RAM usage
for both Fuchsia and Chromium.

Bug: None

--------------------------------------------------------
For Fuchsia

gn-main

Done. Made 184670 targets from 5446 files in 12960ms
Done. Made 184670 targets from 5446 files in 13277ms
Done. Made 184670 targets from 5446 files in 13713ms *
Done. Made 184670 targets from 5446 files in 13882ms
Done. Made 184670 targets from 5446 files in 14259ms

3271324
3275512
3280504 *
3282032
3293832

gn-inherited-libraries

Done. Made 184670 targets from 5446 files in 12248ms
Done. Made 184670 targets from 5446 files in 12267ms
Done. Made 184670 targets from 5446 files in 12326ms *
Done. Made 184670 targets from 5446 files in 12697ms
Done. Made 184670 targets from 5446 files in 12770ms

  DIFF = 13713 - 12326 = 1387ms (-10%)

3026696
3027940
3032296 *
3035976
3037732

   DIFF = 3280504 - 3032296 = 248208 = 242 MiB  (-7.5%)

For Chromium

gn-main

Done. Made 17155 targets from 3025 files in 3289ms
Done. Made 17155 targets from 3025 files in 3314ms
Done. Made 17155 targets from 3025 files in 3328ms *
Done. Made 17155 targets from 3025 files in 3362ms
Done. Made 17155 targets from 3025 files in 3488ms

666764
670480
674792 *
676516
692592

gn-inherited-libraries

Done. Made 17155 targets from 3025 files in 2987ms
Done. Made 17155 targets from 3025 files in 3008ms
Done. Made 17155 targets from 3025 files in 3001ms *
Done. Made 17155 targets from 3025 files in 3021ms
Done. Made 17155 targets from 3025 files in 3106ms

    DIFF = 3328 - 3001 = 327ms  (-9.8%)

613600
616748
618460 *
621900
626768
    DIFF = 674792 - 618460 = 56332 = 55 MiB (-8.3%)

Change-Id: I245367f121cb2b2d542db171146b494209793028
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/12700
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: David Turner <digit@google.com>