tree 1a9898391eca234eff4d9f98641f884658b37ae9
parent 0fcc64f7d006474a026d8f78f3a95dac84cd97ea
author Andrew Grieve <agrieve@google.com> 1749824770 -0700
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1749825040 -0700

Revert "Reland "Run Target::OnResolve() on background threads""

This reverts commit 0fcc64f7d006474a026d8f78f3a95dac84cd97ea.

Reason for revert: Failing to roll into chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/6641508

Bug: chromium:398002893
Original change's description:
> Reland "Run Target::OnResolve() on background threads"
>
> This reverts commit 8ea3af9118a65387fe4d8428db6f59c5927dd55a.
>
> Reason for reland: Fixed test
>
> Bug: chromium:398002893
> Original change's description:
> > Revert "Run Target::OnResolve() on background threads"
> >
> > This reverts commit 3ef7da38dcfb63212d97a987d5c60374134e1007.
> >
> > Reason for revert: Failing tests /w asan (and on release bots)
> >
> > Bug: chromium:398002893
> > Original change's description:
> > > Run Target::OnResolve() on background threads
> > >
> > > OnResolve() is often trivial, but it can also not be, as there are a lot
> > > of possible checks that it can do.
> > >
> > > "gn --tracelog gen" now shows all threads being always busy.
> > >
> > > Hyperfine Benchmark from Chromium:
> > > Before:
> > >   Time (mean ± σ):      7.349 s ±  0.251 s    [User: 66.903 s, System: 50.486 s]
> > >   Range (min … max):    6.974 s …  7.655 s    10 runs
> > >
> > > After:
> > >   Time (mean ± σ):      6.563 s ±  0.313 s    [User: 67.873 s, System: 53.023 s]
> > >   Range (min … max):    6.186 s …  7.281 s    10 runs
> > > Bug: chromium:398002893
> > > Change-Id: I30bd9b7541a961b1d0cef80c229b0a3f24752d3e
> > > Reviewed-on: https://gn-review.googlesource.com/c/gn/+/19020
> > > Reviewed-by: David Turner <digit@google.com>
> > > Commit-Queue: David Turner <digit@google.com>
> > > Reviewed-by: Takuto Ikuta <tikuta@google.com>
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:398002893
> > Change-Id: I4ca499e210288b46a91209967a635004c9d0ad68
> > Reviewed-on: https://gn-review.googlesource.com/c/gn/+/19060
> > Reviewed-by: Andrew Grieve <agrieve@google.com>
> > Commit-Queue: Roland McGrath <mcgrathr@google.com>
> > Reviewed-by: Roland McGrath <mcgrathr@google.com>
>
> # Not skipping CQ checks because this is a reland.
>
> Bug: chromium:398002893
> Change-Id: Ia052c4fb4182bf879e418effcf17f27868131be2
> Reviewed-on: https://gn-review.googlesource.com/c/gn/+/19080
> Commit-Queue: Andrew Grieve <agrieve@google.com>
> Reviewed-by: David Turner <digit@google.com>

TBR=mcgrathr@google.com,tikuta@google.com,agrieve@google.com,digit@google.com,gn-scoped@luci-project-accounts.iam.gserviceaccount.com

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:398002893
Change-Id: I85d6f9b25463afddb8e9c31dd7568170c12c0232
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/19120
Commit-Queue: Andrew Grieve <agrieve@google.com>
Reviewed-by: Andrew Grieve <agrieve@google.com>
Reviewed-by: David Turner <digit@google.com>