)]}'
{
  "commit": "5b4af69f9e815e7e66568bd0b2cc47113e399c66",
  "tree": "4e690db98f59f01397d85c8a2f7d3e2cdec8cd72",
  "parents": [
    "99d236374fdb4b6ea9d69c993f760ea2e967cff5"
  ],
  "author": {
    "name": "Nico Weber",
    "email": "thakis@chromium.org",
    "time": "Thu Nov 07 14:50:24 2019 -0500"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Nov 07 20:17:59 2019 +0000"
  },
  "message": "Fix problems pointed out by building with clang-cl.\n\nAfter https://gn-review.googlesource.com/c/gn/+/6442 it\u0027s fairly\neasy to build with clang-cl (and goma!), so I gave it a try:\n\nset CC\u003dc:\\src\\goma\\goma-win64\\gomacc.exe c:\\src\\chrome\\src\\third_party\\llvm-build\\Release+Asserts\\bin\\clang-cl.exe\nset CXX\u003dc:\\src\\goma\\goma-win64\\gomacc.exe c:\\src\\chrome\\src\\third_party\\llvm-build\\Release+Asserts\\bin\\clang-cl.exe\nset CFLAGS\u003d-Wno-c++11-narrowing\nset LD\u003dc:\\src\\chrome\\src\\third_party\\llvm-build\\Release+Asserts\\bin\\lld-link.exe\npython build\\gen.py\nninja -C out -j100\n\nclang-cl caught a few issues, so this fixes them:\n- remove a few unused private fields\n- remove a few needless std::move() calls that prevent optimizations\n- fix a benign -Wformat warning with char16_t\n- fix some struct/class mismatches\n- make a test actually test what it intended to test\n- remove a const on a value type that had no effect\n- fix field initialization order warnings in Value ctors\n\nNo behavior change.\n\nBug: none\nChange-Id: I816a0382f2ef4f3a42d7945db6db5ce74fa9d5eb\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/6480\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b136670287d5ac227cc7ed332e71bba95b8fdeef",
      "old_mode": 33188,
      "old_path": "src/base/files/file_path.h",
      "new_id": "2359bb69a3561e378143b569331eb07b7c7c7ed2",
      "new_mode": 33188,
      "new_path": "src/base/files/file_path.h"
    },
    {
      "type": "modify",
      "old_id": "9aae16220683437b04cafff89b8f32c9106a467e",
      "old_mode": 33188,
      "old_path": "src/base/files/file_win.cc",
      "new_id": "4bce7df33b266a4d2a496ba9e2d18847d06f9798",
      "new_mode": 33188,
      "new_path": "src/base/files/file_win.cc"
    },
    {
      "type": "modify",
      "old_id": "664dded781fdfbbf5224a3df2ee991801a019543",
      "old_mode": 33188,
      "old_path": "src/base/gtest_prod_util.h",
      "new_id": "b3b1175b2eeab7248d4f2a06518efa8aada97372",
      "new_mode": 33188,
      "new_path": "src/base/gtest_prod_util.h"
    },
    {
      "type": "modify",
      "old_id": "656a87c22ee68d231ae01c87e1f29c713f0ac8a8",
      "old_mode": 33188,
      "old_path": "src/base/json/json_writer.cc",
      "new_id": "912a7f0ad50fd493e0dd3c3e5bad7d55a4c79551",
      "new_mode": 33188,
      "new_path": "src/base/json/json_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "7edd3a68680c950a343ea99a02bbe6530ddbadf8",
      "old_mode": 33188,
      "old_path": "src/base/json/json_writer.h",
      "new_id": "4114f7772ee61a99e94c9c994c445b9bf334ff21",
      "new_mode": 33188,
      "new_path": "src/base/json/json_writer.h"
    },
    {
      "type": "modify",
      "old_id": "a8ccd6faac77ec1269ff2afaa1c15a987ec2b419",
      "old_mode": 33188,
      "old_path": "src/base/logging.cc",
      "new_id": "ee60c4703a1f4643754429c218a3edcef6e2e8f1",
      "new_mode": 33188,
      "new_path": "src/base/logging.cc"
    },
    {
      "type": "modify",
      "old_id": "c581d33c46e7ac1572453ecd2ab156ad7e7f37a5",
      "old_mode": 33188,
      "old_path": "src/base/logging.h",
      "new_id": "78cad59d179a1d76e6bb8e3c38efef2e45c98164",
      "new_mode": 33188,
      "new_path": "src/base/logging.h"
    },
    {
      "type": "modify",
      "old_id": "11afbf391b0e884fb3f74de98806c34c65ebf15e",
      "old_mode": 33188,
      "old_path": "src/gn/compile_commands_writer.cc",
      "new_id": "10984cc33fad95e36fb203579c42bc221b92d521",
      "new_mode": 33188,
      "new_path": "src/gn/compile_commands_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "e52bb6a75219d8330afe14ff38c4645852a2a575",
      "old_mode": 33188,
      "old_path": "src/gn/desc_builder.cc",
      "new_id": "57b253d38ecf20dad0dcc4bcf6a636332f4f76ea",
      "new_mode": 33188,
      "new_path": "src/gn/desc_builder.cc"
    },
    {
      "type": "modify",
      "old_id": "f79b75326af0890c76063c5b90fc3bcb3676e7c4",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_c_binary_target_writer_unittest.cc",
      "new_id": "48ff9e4d28bb260ee15058ad0674432ea456d243",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_c_binary_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "a2f77bce3e8e94b1676610f166641645a7a95104",
      "old_mode": 33188,
      "old_path": "src/gn/parse_tree.cc",
      "new_id": "e1fc5a542c3e80fa4e731c674fe79be1cdbcc22c",
      "new_mode": 33188,
      "new_path": "src/gn/parse_tree.cc"
    },
    {
      "type": "modify",
      "old_id": "d666f5a1523ce51f941b89579bb280cc1f4f90c2",
      "old_mode": 33188,
      "old_path": "src/gn/rust_values.h",
      "new_id": "9770e343a3f4424e5828fe2bc4da352084512e36",
      "new_mode": 33188,
      "new_path": "src/gn/rust_values.h"
    },
    {
      "type": "modify",
      "old_id": "233a523128a71af404fbe4aeb521347b7c1e5c9a",
      "old_mode": 33188,
      "old_path": "src/gn/value.cc",
      "new_id": "c3bb9b512c744f524af3ab70b1983eac61fdaa4e",
      "new_mode": 33188,
      "new_path": "src/gn/value.cc"
    },
    {
      "type": "modify",
      "old_id": "b5539d7fa4d9da5517cb4378afb16ef2d7d52778",
      "old_mode": 33188,
      "old_path": "src/util/test/test.h",
      "new_id": "d3fc056fdc2a108939a2220adbcfe59ac5a849b0",
      "new_mode": 33188,
      "new_path": "src/util/test/test.h"
    }
  ]
}