commit | 5d9a4e9ad387a7a914b7f82d298e2615602c7a11 | [log] [tgz] |
---|---|---|
author | Petr Hosek <phosek@google.com> | Fri Jul 20 17:33:21 2018 -0700 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Jul 21 01:45:33 2018 +0000 |
tree | d054a02d78c509f21573194e5e8ca06d0b94e289 | |
parent | d7111cb6877187d1f378bd231e14ffdd5fdd87ae [diff] |
Make ICF an option in gen.py Previously, ICF was enabled unconditionally for all release builds but this is causing issue when using ld.bfd as a linker because ICF is not supported there, so we make it an option which can be enabled as needed. Change-Id: Id648184d932457f3481339ed265d9ad133ce3c98 Reviewed-on: https://gn-review.googlesource.com/2320 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org>
GN is a meta-build system that generates build files for Ninja.
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out
On Windows, it is expected that cl.exe
, link.exe
, and lib.exe
can be found in PATH
, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++
, a recent version is expected to be found in PATH
. This can be overridden by setting CC
, CXX
, and AR
.
GN uses Gerrit for code review. The short version of how to patch is:
... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git push origin HEAD:refs/for/master # This uploads for review.
When revising a change, use:
git commit --amend git push origin HEAD:refs/for/master
which will add the new changes to the existing code review, rather than creating a new one.
TODO: AUTHORS, CLA, etc.