commit 5dca6f172912264399c948abf67c6de67d6b99c9
author sdefresne <sdefresne@chromium.org> Sat Mar 19 06:34:28 2016 -0700
committer Commit bot <commit-bot@chromium.org> Sat Mar 19 13:35:59 2016 +0000
tree fdbd1084f299b0e9a290a972c88e1b833cb57993
parent 7e91550db2877d4b293f76f8e98f6b1225b72dbe

[GN] Fix "gn gen --ide=vs" to ignore bundle_data targets.

In order to keep the BUILD.gn more readable by avoiding conditionals,
Chromium defines bundle_data on every platforms (as in the absence of
create_bundle they are just no-op stamp targets).

Fix "gn gen --ide=vs" to ignore bundle_data targets but not the
create_bundle targets (as there should be no such targets on Windows).

BUG=595915

Review URL: https://codereview.chromium.org/1811203003

Cr-Original-Commit-Position: refs/heads/master@{#382197}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a90c62f80a74f7abc647234f70ac596e86bf3dd2

tools/gn/visual_studio_writer.cc

diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc
index 54a7bf2..801ea77 100644
--- a/tools/gn/visual_studio_writer.cc
+++ b/tools/gn/visual_studio_writer.cc
@@ -259,11 +259,12 @@
   writer.folders_.reserve(targets.size());
 
   for (const Target* target : targets) {
-    // Skip actions and groups.
+    // Skip actions, groups and bundle targets.
     if (target->output_type() == Target::GROUP ||
         target->output_type() == Target::COPY_FILES ||
         target->output_type() == Target::ACTION ||
-        target->output_type() == Target::ACTION_FOREACH) {
+        target->output_type() == Target::ACTION_FOREACH ||
+        target->output_type() == Target::BUNDLE_DATA) {
       continue;
     }