tree dfb1b332190cab68cd9ac157e730b73068719a43
parent 9703eb75389191c321d93bf7a6a6cf695584c91f
author Sylvain Defresne <sdefresne@chromium.org> 1670865636 +0100
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1670868919 +0000

Consider application bundle as executable for phony targets

When generating phony short names for target, consider that targets
creating bundle with type "com.apple.product-type.application" as
executables.

This will help ensure that when targeting the iOS platform, it is
possible to build the application bundle using their short name
even if some third-party dependency use the same name.

Recently building Chrome on iOS from the command-line using
`ninja -C out/Debug chrome` was broken for the second time due
to a change in perfetto adding a target named "chrome".

Note that on iOS it is not possible to run an executable that is
not in an application bundle, so the rule that prefer executable
target was not working there.

Bug: chromium:1383100
Change-Id: Iab62336fa37db8fab0dc84affa2cfab65e0e60f9
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/14920
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>