tree 452e4b206a57ee3e80f95db1ee6e62fc3d2a4acb
parent c147fde58d9de7fddb202a4e4e01f9763bc58af1
author Dmitry Skiba <dskiba@chromium.org> 1500545557 +0000
committer Commit Bot <commit-bot@chromium.org> 1500545557 +0000

Revert "[tracing] Switch to new heap dump format."

This reverts commit d4a5e98235da0cc8c4fb1ae2f67826b0b480ce4c.

Reason for revert: regressed performance (crbug.com/739378, crbug.com/736714).

The main cause is that new heap format produces a lot more stack frames in
an attempt to dump all information in contrast with the old format, where
small stack branches are coalesced together. I'll that functionality to
the new format and reland it.

> [tracing] Switch to new heap dump format.
>
> This CL switches tracing to a new heap dump format, that offers the
> following advantages:
>
> 1. Dumps include all the information collected by Chrome's heap profiler.
>
> 2. The format is simpler and more compact.
>
> 3. The format can easily be extended to include additional per-entry data.
>
> 4. The format allows for post-processing (see recategorization from
>    crrev.com/2906413002 as an example).
>
> BUG=708930
>
> Review-Url: https://codereview.chromium.org/2650863003
> Cr-Commit-Position: refs/heads/master@{#480580}

TBR=mark@chromium.org

Bug: 708930, 739378, 736714
Change-Id: Ifc2b647aa1f57f4decae6e593ad032d72208b304
Reviewed-on: https://chromium-review.googlesource.com/575682
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488186}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd1180754539805af312a7f2ac52f758d543226f