| commit | d9bca564b807d24091efff8de94c8556c8eb06eb | [log] [tgz] |
|---|---|---|
| author | Tom Anderson <thomasanderson@chromium.org> | Fri Jul 13 12:39:29 2018 -0700 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 13 20:05:38 2018 +0000 |
| tree | c68748761571663dad7cf46a025b3357ede43faa | |
| parent | 0e4f3935ee53741240a69b877a6a9aed78f62950 [diff] |
Fixes for --out-path and --no-sysroot This is a followup to [1]. Adds the build dir to the include path so the compiler can find last_commit_position.h when the build dir is not "out". Adds the necessary libs back on Linux when using --no-sysroot. [1] https://gn.googlesource.com/gn/+/0e4f3935ee53741240a69b877a6a9aed78f62950 BUG=chromium:863460 R=brettw Change-Id: Id76e88245d7b0a2489205700964d657e63acb59e Reviewed-on: https://gn-review.googlesource.com/2180 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org>
GN is a meta-build system that generates build files for Ninja.
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out
On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.
GN uses Gerrit for code review. The short version of how to patch is:
... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git push origin HEAD:refs/for/master # This uploads for review.
When revising a change, use:
git commit --amend git push origin HEAD:refs/for/master
which will add the new changes to the existing code review, rather than creating a new one.
TODO: AUTHORS, CLA, etc.