)]}'
{
  "commit": "69ce30f4d1fdddfa88a141537e7b7970ea8c588f",
  "tree": "f1bbef0febbb94b08e3dbd635ba4f91da331b174",
  "parents": [
    "513d8405b795445930e28112f286d075d8ca8fa2"
  ],
  "author": {
    "name": "brettw",
    "email": "brettw@chromium.org",
    "time": "Fri Nov 11 14:24:21 2016 -0800"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Nov 11 22:43:36 2016 +0000"
  },
  "message": "GN: Always check for bad items.\n\nPrevious checking for most types of errors in the GN introspection commands was\ndisabled. The reason was that it can be convenient to ask for certain types\nof information which GN can provide even if there are errors elsewhere in the\nbuild.\n\nUnfortunately, not checking for bad items can leave the build graph in an\ninconsistent state. In the case of missing dependencies, a target will never\nbe resolved which means most of the information the tools will return about it\nwill be missing or incorrect which is very surprising and confusing.\n\nAs a result, it seems best to always ensure things are in a consistent state\nbefore running any introspection calculations.\n\nReview-Url: https://codereview.chromium.org/2492273002\nCr-Original-Commit-Position: refs/heads/master@{#431667}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f77e13a490ea98bed6f136661fa778ba3972b8e1\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "14f1aa8697b393334c326d594cc0c2693fa3e21d",
      "old_mode": 33188,
      "old_path": "tools/gn/build_settings.cc",
      "new_id": "3fac976202ad1f5125d2485826e5ec99c8a471a3",
      "new_mode": 33188,
      "new_path": "tools/gn/build_settings.cc"
    },
    {
      "type": "modify",
      "old_id": "5424cf9523440faa55d66098fd9df6fda15e1c6e",
      "old_mode": 33188,
      "old_path": "tools/gn/build_settings.h",
      "new_id": "0b986cd6aeab677c3aecd7078421199e55abba72",
      "new_mode": 33188,
      "new_path": "tools/gn/build_settings.h"
    },
    {
      "type": "modify",
      "old_id": "ee3774ccdb77b302802317d8a2d4d9627c359f0a",
      "old_mode": 33188,
      "old_path": "tools/gn/command_analyze.cc",
      "new_id": "6fd582356097f55d8f3326fe36c977b25a565422",
      "new_mode": 33188,
      "new_path": "tools/gn/command_analyze.cc"
    },
    {
      "type": "modify",
      "old_id": "374a274a73919d3ad2599b9515d96e184512a826",
      "old_mode": 33188,
      "old_path": "tools/gn/command_args.cc",
      "new_id": "1b81135be3d9ff23e632380568d956c8ec4661b5",
      "new_mode": 33188,
      "new_path": "tools/gn/command_args.cc"
    },
    {
      "type": "modify",
      "old_id": "2257221aaecd4502637b16570cda9ec16dd8ddc0",
      "old_mode": 33188,
      "old_path": "tools/gn/command_desc.cc",
      "new_id": "9f7f903c986d2edb3ccb307a11b817d1f0f0aa98",
      "new_mode": 33188,
      "new_path": "tools/gn/command_desc.cc"
    },
    {
      "type": "modify",
      "old_id": "676ff579a166734144acfe1a0f375a6d7fd72916",
      "old_mode": 33188,
      "old_path": "tools/gn/command_ls.cc",
      "new_id": "58b9c8759513accb5da5ba6f143560a3a3474773",
      "new_mode": 33188,
      "new_path": "tools/gn/command_ls.cc"
    },
    {
      "type": "modify",
      "old_id": "6fa014644f5598c8aea28422cf2b11e1d6bf44be",
      "old_mode": 33188,
      "old_path": "tools/gn/command_refs.cc",
      "new_id": "4d7ad7b5b3309cbf5237a9faa3b2fdeef8e61199",
      "new_mode": 33188,
      "new_path": "tools/gn/command_refs.cc"
    },
    {
      "type": "modify",
      "old_id": "c5eace2219f5df5f38f477d82159e7108309c381",
      "old_mode": 33188,
      "old_path": "tools/gn/setup.cc",
      "new_id": "8a433bcdbb1cacf67fd0e96bdbaf5f5bee9dc360",
      "new_mode": 33188,
      "new_path": "tools/gn/setup.cc"
    },
    {
      "type": "modify",
      "old_id": "aafdc4fedce82579452e522357e17519127e483e",
      "old_mode": 33188,
      "old_path": "tools/gn/target.cc",
      "new_id": "49de35df03ea09d117b31716175b80035a89d83f",
      "new_mode": 33188,
      "new_path": "tools/gn/target.cc"
    }
  ]
}
