tree f1bbef0febbb94b08e3dbd635ba4f91da331b174
parent 513d8405b795445930e28112f286d075d8ca8fa2
author brettw <brettw@chromium.org> 1478903061 -0800
committer Commit bot <commit-bot@chromium.org> 1478904216 +0000

GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of missing dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect which is very surprising and confusing.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.

Review-Url: https://codereview.chromium.org/2492273002
Cr-Original-Commit-Position: refs/heads/master@{#431667}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f77e13a490ea98bed6f136661fa778ba3972b8e1