gn /
gn /
6bb51cf3ddd7eb29c3d9fe5ea418e366a25009ae tools/gn: rename char_offset to column_number
While looking at Location and trying to understand what char offset meant,
I got very confused, because in some languages, like Portuguese, it is
hard to translate offset and thus understand what it means. Actually
char offset is referring to the column number in text buffer, which is much
easier to understand and its meaning is instantly understood, since everyone is
familiar with the concenpt of rows (lines) and columns in a text editor.
BUG=None
TEST=gn gen + gn_unittests
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1525183002
Cr-Original-Commit-Position: refs/heads/master@{#367883}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 21aff0d0e90b1fc419971485150f76c4d2458e13
13 files changed
tree: f1b8a761a3cff1345a1c005bfa87722b501e271a
- tools/