commit 747859275a3786b2b9b3d0f2b3c0639c3f8c70c5
author jdoerrie <jdoerrie@chromium.org> Wed Aug 02 23:25:52 2017 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Aug 02 23:25:52 2017 +0000
tree 5744d2b746b45b4c89429d8f370ae0b2dab42bc0
parent 878599977df1a328ffeda0769c082ba17b9ac277

Remove base::Value::SetBooleanWithoutPathExpansion

This change removes the deprecated SetBooleanWithoutPathExpansion from
base::Value. Existing usages are replaced by SetKey(key, Value(bool)).

Bug: 646113
Change-Id: I4d7f1a60909765ec6a956360312c11b32173429f
Reviewed-on: https://chromium-review.googlesource.com/590448
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491549}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1e4eeb8981f9fe906e29bf830dc0c41536ee561f

tools/gn/desc_builder.cc

diff --git a/tools/gn/desc_builder.cc b/tools/gn/desc_builder.cc
index 965ec92..bcf4dc6 100644
--- a/tools/gn/desc_builder.cc
+++ b/tools/gn/desc_builder.cc
@@ -273,13 +273,12 @@
                                    target_->visibility().AsValue());
 
     if (what(variables::kTestonly))
-      res->SetBooleanWithoutPathExpansion(variables::kTestonly,
-                                          target_->testonly());
+      res->SetKey(variables::kTestonly, base::Value(target_->testonly()));
 
     if (is_binary_output) {
       if (what(variables::kCheckIncludes))
-        res->SetBooleanWithoutPathExpansion(variables::kCheckIncludes,
-                                            target_->check_includes());
+        res->SetKey(variables::kCheckIncludes,
+                    base::Value(target_->check_includes()));
 
       if (what(variables::kAllowCircularIncludesFrom)) {
         auto labels = base::MakeUnique<base::ListValue>();