commit 8380b75e72cabe8761ac9ddb86359c627e976bd4
author Chris Palmer <palmer@chromium.org> Mon Mar 05 23:34:29 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Mar 05 23:34:29 2018 +0000
tree 3060982599c18075b7bb2064d58839512e191be2
parent d62f36719abdcf63bf97f246d159ca05745bc204

Correct off-by-one in `Tokenizer::CanIncrement`.

It would return true even if you were actually at the end of the input.

Bug: 818844
Change-Id: I0ba5be52b568e39a087efc1e8114138ac4c18799
Reviewed-on: https://chromium-review.googlesource.com/949963
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540982}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6783e46fa01a4da9c9b764d1858eb3c3f9b03f9e

tools/gn/tokenizer.h

diff --git a/tools/gn/tokenizer.h b/tools/gn/tokenizer.h
index 9b6ef33..67590df 100644
--- a/tools/gn/tokenizer.h
+++ b/tools/gn/tokenizer.h
@@ -57,7 +57,7 @@
   bool IsCurrentNewline() const;
   bool IsCurrentStringTerminator(char quote_char) const;
 
-  bool CanIncrement() const { return cur_ < input_.size(); }
+  bool CanIncrement() const { return cur_ < input_.size() - 1; }
 
   // Increments the current location by one.
   void Advance();