Add support escape JSON string to stream for export compile commands

gn gen --export-compile-commands does not produce valid JSON
The resulting file has "command" entries which are invalid JSON:
they are strings containing unescaped double quotation marks,
like "command": "... /showIncludes "..." "..." "..."".

Added new function EscapeJSONStringToStream that escape strings suitable
for JSON to generate compile_commands.json with valid JSON. This function
works the same as EscapeString but escape JSON string and writes the
results to the given stream, saving a copy.

Made EscapeJSONString return void and deleting the GetQuotedJSONString in
string_escape.*.

Added unit-test for EscapeJSONStringToStream function to escape_unittest.cc

Change-Id: I39c313314a186cb1de0280494cba3b546e5d1a1d
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/8520
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
6 files changed
tree: 911cd457a910434eb7aa2db89eae1cfef969a154
  1. build/
  2. docs/
  3. examples/
  4. infra/
  5. misc/
  6. src/
  7. tools/
  8. .clang-format
  9. .editorconfig
  10. .gitignore
  11. .style.yapf
  12. AUTHORS
  13. LICENSE
  14. OWNERS
  15. README.md
README.md

GN

GN is a meta-build system that generates build files for Ninja.

Related resources:

Getting a binary

You can download the latest version of GN binary for Linux, macOS and Windows.

Alternatively, you can build GN from source:

git clone https://gn.googlesource.com/gn
cd gn
python build/gen.py
ninja -C out
# To run tests:
out/gn_unittests

On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.

On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.

Examples

There is a simple example in examples/simple_build directory that is a good place to get started with the minimal configuration.

To build and run the simple example with the default gcc compiler:

cd examples/simple_build
../../out/gn gen -C out
ninja -C out
./out/hello

For a maximal configuration see the Chromium setup:

and the Fuchsia setup:

Reporting bugs

If you find a bug, you can see if it is known or report it in the bug database.

Sending patches

GN uses Gerrit for code review. The short version of how to patch is:

Register at https://gn-review.googlesource.com.

... edit code ...
ninja -C out && out/gn_unittests

Then, to upload a change for review:

git commit
git push origin HEAD:refs/for/master

The first time you do this you'll get an error from the server about a missing change-ID. Follow the directions in the error message to install the change-ID hook and run git commit --amend to apply the hook to the current commit.

When revising a change, use:

git commit --amend
git push origin HEAD:refs/for/master

which will add the new changes to the existing code review, rather than creating a new one.

We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).

Community

You may ask questions and follow along with GN‘s development on Chromium’s gn-dev@ Google Group.