)]}'
{
  "commit": "8730b0feb6b991fa47368566501ab9ccfb453c92",
  "tree": "3c325948931e7bb69b785d4a7353e946013911fd",
  "parents": [
    "0d038c2e0a32a528713d3dfaf1f1e0cdfe87fd46"
  ],
  "author": {
    "name": "Tom Anderson",
    "email": "thomasanderson@chromium.org",
    "time": "Thu May 16 11:00:40 2019 -0700"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu May 16 21:36:50 2019 +0000"
  },
  "message": "Disallow non-buildable sources in binary targets\n\nWhen adding a file that\u0027s not a source, header, or object file to a source_set,\nloadable_module, shared_library, executable, or static_library, gn will now\ngenerate an error like the following:\n\nERROR at //third_party/protobuf/proto_library.gni:369:15: Only source, header,\nand object files belong in the sources of a\nsource_set. //out/Test/pyproto/google_apis/gcm/protocol/mcs_pb2.py is not one of\nthe valid types.\n    sources \u003d get_target_outputs(\":$action_name\")\n              ^---------------------------------\nSee //google_apis/gcm/BUILD.gn:78:1: whence it was called.\nproto_library(\"proto\") {\n^-----------------------\nSee //BUILD.gn:89:7: which caused the file to be included.\n      \"//google_apis/gcm:gcm_unit_tests\",\n      ^---------------------------------\n\nBUG\u003d77\nR\u003dbrettw\n\nChange-Id: I4ed8da10c48e3e5d74f79e51d8222c998a7b883a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/4980\nCommit-Queue: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "60af24237e4f62f9f44c58cac279d46ff1623555",
      "old_mode": 33188,
      "old_path": "tools/gn/binary_target_generator.cc",
      "new_id": "6d8cec926ffa609460cef89c6b27d8412db5b22d",
      "new_mode": 33188,
      "new_path": "tools/gn/binary_target_generator.cc"
    },
    {
      "type": "modify",
      "old_id": "40fc3141e26a0621ea51d434b07fc78560418b3b",
      "old_mode": 33188,
      "old_path": "tools/gn/binary_target_generator.h",
      "new_id": "6cbd11ea41f433358cecaf442f2994a382cd71dd",
      "new_mode": 33188,
      "new_path": "tools/gn/binary_target_generator.h"
    },
    {
      "type": "modify",
      "old_id": "0fd5c75a88de8ddaf8aed452086b950cf4608b1b",
      "old_mode": 33188,
      "old_path": "tools/gn/source_dir.cc",
      "new_id": "50b45175634687bcd48919fd28feae7b1fa47c9e",
      "new_mode": 33188,
      "new_path": "tools/gn/source_dir.cc"
    },
    {
      "type": "modify",
      "old_id": "7c860d43cb7e4269378190ba714911e5dc4a9f5b",
      "old_mode": 33188,
      "old_path": "tools/gn/source_file.cc",
      "new_id": "2923227419cdda50b31b2ed5001c09bdcd223b0a",
      "new_mode": 33188,
      "new_path": "tools/gn/source_file.cc"
    },
    {
      "type": "modify",
      "old_id": "bcf5f422530ac3c568cc04443c9c4b09363f9074",
      "old_mode": 33188,
      "old_path": "tools/gn/source_file.h",
      "new_id": "d42063d6a8addfa60c748a74faffe93a1d22f631",
      "new_mode": 33188,
      "new_path": "tools/gn/source_file.h"
    },
    {
      "type": "modify",
      "old_id": "627505da2da25ad091947a1deb55f6e4a5685b80",
      "old_mode": 33188,
      "old_path": "tools/gn/target_generator.h",
      "new_id": "8795cbf99fdaf12ae2ba0142b4f2c819f0a68d7c",
      "new_mode": 33188,
      "new_path": "tools/gn/target_generator.h"
    }
  ]
}