tree 3c325948931e7bb69b785d4a7353e946013911fd
parent 0d038c2e0a32a528713d3dfaf1f1e0cdfe87fd46
author Tom Anderson <thomasanderson@chromium.org> 1558029640 -0700
committer Commit Bot <commit-bot@chromium.org> 1558042610 +0000

Disallow non-buildable sources in binary targets

When adding a file that's not a source, header, or object file to a source_set,
loadable_module, shared_library, executable, or static_library, gn will now
generate an error like the following:

ERROR at //third_party/protobuf/proto_library.gni:369:15: Only source, header,
and object files belong in the sources of a
source_set. //out/Test/pyproto/google_apis/gcm/protocol/mcs_pb2.py is not one of
the valid types.
    sources = get_target_outputs(":$action_name")
              ^---------------------------------
See //google_apis/gcm/BUILD.gn:78:1: whence it was called.
proto_library("proto") {
^-----------------------
See //BUILD.gn:89:7: which caused the file to be included.
      "//google_apis/gcm:gcm_unit_tests",
      ^---------------------------------

BUG=77
R=brettw

Change-Id: I4ed8da10c48e3e5d74f79e51d8222c998a7b883a
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/4980
Commit-Queue: Brett Wilson <brettw@google.com>
Reviewed-by: Brett Wilson <brettw@google.com>