)]}'
{
  "commit": "892ce1b15308150072d6cd8af74632411f126906",
  "tree": "0b03baac7238d3064d92bdb32d7955c088ae1be9",
  "parents": [
    "9f10c6dde5691a27e15f03d571ee4d0487dfba03"
  ],
  "author": {
    "name": "Brett Wilson",
    "email": "brettw@chromium.org",
    "time": "Mon Feb 05 17:54:27 2018 +0000"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Feb 05 17:54:27 2018 +0000"
  },
  "message": "Only run \"gn check\" on binary targets.\n\nWe ran into a case where a copy step triggered a check failure because the\nsource of a copy had a .h extension. But copy targets should not trigger header\nchecking.\n\nThis change excludes non-binary targets from checking altogether.\n\nWriting a test for this ended up being quite involved. The existing header\nchecker tests all tie in at a lower layer to avoid complicated dependencies on\nreal files. In the end, I decided the benefit of a test for this check is not\nworth the added complexity (and potential flakiness) of adding a new class of\ncheck tests that use actual files.\n\nChange-Id: I819db52d791cf3b4683fca584937f16ec4a14200\nReviewed-on: https://chromium-review.googlesource.com/899930\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#534416}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b46dd8bef522b08b069db7d42506bc416b555f34",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ac8214b79377bca2012396dd5b16adfb3a7db926",
      "old_mode": 33188,
      "old_path": "tools/gn/header_checker.cc",
      "new_id": "c47e6f1f3e0682117414ef57f5b905021741f05b",
      "new_mode": 33188,
      "new_path": "tools/gn/header_checker.cc"
    }
  ]
}
